神器1456~1462（アイスブランドアーツとその生成先）、それに使用するオブジェクト(1161)の作成#2044
Open
ogachu0331 wants to merge 15 commits into
Open
Conversation
Lapis-LJA
requested changes
Jun 5, 2026
Contributor
Lapis-LJA
left a comment
Lapis-LJA
left a comment
There was a problem hiding this comment.
各武器用のobjectが用意されてるけど、内部処理は全く同じっぽいから1つに纏めるべきと感じた。
神器側で召喚時にCustomModelDataを設定してやればいい気がする
ogachu0331
changed the title
Author
object#1161の処理にまとめました！ファイルの名前も変えました |
Author
|
全ての修正と仕様変更終わりましたので再レビューお願いします |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
テクスチャはまだなのと、威力とmp、cdは塩梅があまりわかってないのでなんとなくです。