Repository navigation
study_saturation: record DDSketch mean relative value error - #176
Merged
milindsrivastava1997 merged 1 commit intoOct 7, 2026
Conversation
The optimizer reads DD by mean_relative_value_error; the study wrote max_relative_value_error, so SaturationCurves::accuracy would panic on the metric mismatch. Judge DD on mean error, like KLL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
milindsrivastava1997
deleted the
175-saturation-study-records-ddsketch-max-relative-value-error-optimizer-reads-mean
branch
October 7, 2026 16:30
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175 (step 1).
scripts/study_saturation.pynow records DD curves asmean_relative_value_error(wasmax_relative_value_error), matching whatrqe-optimizerreads fordd(#173).Design decisions (please approve)
Not in this PR
max_*until then.small_problemruns with a Quantile RAQE and no panic (step 3). This depends on step 2.Test
python3 -m pytest scripts/test_study_saturation.py: 26 passed.🤖 Generated with Claude Code