Repository navigation
docs(asapv1): metadata key names; SetAggregator delta at 08 80 - #217
Merged
Merged
Conversation
Renames the metadata keys listed in #187 so one concept has one key in every kind: heap_size, layers, rows/cols, plural tier dimensions, cell_* for Hydra cells, compaction_seed for KLL, admission_rate for the sampling probability. SetAggregator delta moves to 08 80 and 09 00 is retired. UnivMon-Q's section is written in layers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187. Part of #179.
Spec only:
docs/asapv1_wire_format.md. Rust and Go code, the API docs and the golden files follow in phase 2.What the bytes changes reach
seedinto KLL frames when its OTAP KLL sketch is configured with a seed.1. Metadata keys
kheap_sizelayer_sizelayerssketch_row,sketch_colrows,colselephant_row,elephant_col,mouse_row,mouse_colelephant_rows,elephant_cols,mouse_rows,mouse_colscandidatesheap_sizelevelslayersdepth,widthrows,top_layer_colswidth_halving_periodcols_halving_periodcounter_k,counter_m,counter_item_typecell_k,cell_m,cell_item_typecounter_rows,counter_cols,counter_type,counter_modecell_rows,cell_cols,cell_counter_type,cell_modecounter_precisioncell_precisioncounter_layer_size,counter_sketch_row,counter_sketch_col,counter_heap_size,counter_key_typecell_layers,cell_rows,cell_cols,cell_heap_size,cell_key_typeseedcompaction_seedsample_padmission_rate2. kind_id: SetAggregator delta moves from
09 00to08 80A delta's kind_id is its state's kind_id with the top bit of the variant byte set. SetAggregator is
08 00, so its delta is08 80.09 00is retired and never reassigned.The spec also states that the
seedlistin thehash_profile_idvalue is part of the fixed id, and writes UnivMon-Q's section in layers.🤖 Generated with Claude Code