Repository navigation
Conversation
Downstream crates (ASAPPlanner, ASAPQuery-backend) decode the protobuf SketchEnvelope for KLL and DDSketch states. Host these helpers next to the sketch definitions instead of in a separate ASAPPlanner crate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
12 of 46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The
SketchEnvelopedecoding and encoding helpers (envelope_state,ddsketch_state,reconstruct_ddsketch,kll_state,encode_ddsketch,encode_kll) lived in the ASAPPlanner crateasap_sketch_codec, and both ASAPPlanner and ASAPQuery-backend depended on it.After this PR
The helpers live in sketchlib as
asap_sketchlib::proto::envelope, with unchanged names and signatures, so callers only change the import path. ASAPPlanner no longer needs the codec (ProjectASAP/ASAPPlanner#473), and Backend will import it from sketchlib. No new dependencies.Validation:
cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings(all four CI feature sets),cargo docwith-D warnings, andcargo test --all-features --lockedpass, including 7 new tests inproto::envelope.🤖 Generated with Claude Code