Repository navigation
fix(query-engine): stub bench_ingest_sender in the Dockerfile dependency layer - #832
Merged
Merged
Conversation
…ncy layer #825 added the bench_ingest_sender [[bin]] without a stub, so the cached dependency build can't find it and every query-engine image build fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
#825 added a
bench_ingest_sender[[bin]]toasap-query-engine/Cargo.tomlbut no stub in the Dockerfile's dependency-cache layer. Every query-engine image build fails since then, on main (c06d609) and on every PR (e.g. #828):After this PR
The stub is added next to the other
[[bin]]stubs.Validation
docker build -f asap-query-engine/Dockerfile .(the Rust CI step) succeeds locally.🤖 Generated with Claude Code