Repository navigation
Remove Flink, Arroyo, asap-summary-ingest, and legacy Kafka-ingest infra from asap-tools #709
Copy link
Copy link
Closed
Description
Summary
Remove Flink, Arroyo, asap-summary-ingest, and the legacy Kafka-ingest path (streaming_engine=flink|arroyo, use_kafka_ingest) from asap-tools and the repo root. precompute (HTTP remote write) is the only supported streaming engine going forward.
Directories to delete entirely
asap-summary-ingest/(repo root — the Arroyo pipeline project)asap-tools/installation/arroyo/,asap-tools/installation/flink/,asap-tools/installation/prometheus_kafka_adapter/asap-tools/execution-utilities/asap_query_latency/asap-tools/execution-utilities/asap_benchmark_pipeline/asap-tools/execution-utilities/high-throughput-kafka-producer/,high-throughput-kafka-producer-single-threaded/asap-tools/execution-utilities/kafka-consumer/,kafka_toy_data_generator/asap-tools/execution-utilities/clickhouse-benchmark-pipeline/asap-common/dependencies/py/promql_utilities/promql_utilities/streaming_config/(MetricConfig,SQLTableConfig,StreamingAggregationConfig) — its only consumer isasap-summary-ingest/run_arroyosketch.pyand that package's own tests; dead onceasap-summary-ingest/is deletedasap-common/dependencies/py/promql_utilities/promql_utilities/query_logics/(logics.py,parsing.py,enums.py) — already has zero importers anywhere in the Python codebase today (confirmed by audit), independent of the Arroyo removal. Note: the Rust crate'squery_logicsmodule (asap-common/dependencies/rs/promql_utilities/src/query_logics/) is heavily used byasap-planner-rs/asap-query-engine/asap_typesand is out of scope — only the Python port is dead.
Files to delete entirely
asap-tools/docker/arroyo-cli-compose.ymlasap-tools/experiments/experiment_utils/services/flink.pyasap-tools/experiments/experiment_utils/services/arroyo.pyasap-tools/experiments/experiment_utils/services/arroyo_throughput_monitor.pyasap-tools/experiments/experiment_utils/services/prometheus_kafka_adapter.pyasap-tools/experiments/experiment_utils/services/kafka.pyasap-tools/experiments/generate_arroyosketch_compose.pyasap-tools/experiments/dumb_kafka_consumer_arroyo.pyasap-tools/experiments/arroyo_throughput_monitor.pyasap-tools/experiments/config/overrides/arroyo.yamlasap-tools/installation/recompile_flink.shasap-tools/installation/empty_flink_logs.sh
Files needing edits (not full deletes)
asap-tools/components.conf— dropasap-summary-ingestlineasap-tools/installation/install_external_components.sh— remove"flink","arroyo"fromPREDEFINED_COMPONENTSasap-tools/docker/asap-docker-compose.yml— drop thearroyo-cli-compose.yml/arroyosketch-compose.ymlincludesasap-tools/experiments/constants.py— dropFLINK_INPUT_TOPIC,FLINK_OUTPUT_TOPIC,KAFKA_BROKER,ARROYO_IMAGE,ARROYO_THROUGHPUT_POLLING_INTERVAL,AVOID_RUN_ARROYOSKETCH_LONG_SSHasap-tools/experiments/experiment_utils/services/__init__.py— removeKafka/Flink/Arroyo/PrometheusKafkaAdapter/DumbKafkaConsumerimportsasap-tools/experiments/experiment_utils/services/query_engine.py— dropstreaming_engine="arroyo"/kafka-ingest branch andkafka_broker/flink_output_formatparams, keep onlyprecomputeasap-tools/experiments/experiment_run_e2e.py,experiment_teardown_everything.py,experiment_only_ingest_path.py,experiment_run_grafana_demo.py,experiment_run_clickhouse.py— strip Kafka/Flink/Arroyo service setup, teardown, anduse_kafka_ingest/streaming_engine=flink|arroyobranchesasap-tools/experiments/generate_controller_compose.py— drop"flink"/"arroyo"fromstreaming_enginechoicesasap-tools/experiments/experiment_utils/config.py— remove flink/arroyo/kafka config validation branchesasap-tools/experiments/experiment_utils/services/misc.py— removeDumbKafkaConsumerServiceasap-tools/experiments/experiment_utils/providers/local.py— remove flink/arroyo-specific provider hooksasap-tools/experiments/config/config.yaml— dropuse_kafka_ingestasap-tools/experiments/config/experiment_type/ingest_path_v2.yaml— check for kafka/flink knobsasap-tools/README.md,asap-tools/docs/architecture.md,configuration.md,deployment.md,troubleshooting.md,experiments/CONFIG_PARAMETERS_REFERENCE.md,experiments/HYDRA_CONFIG_USAGE.md— rewrite; these document Flink/Arroyo as first-class streaming engines and the Kafka ingest data flow- Top-level
docs/02-components/README.md,docs/01-getting-started/architecture.md,docs/README.md,docs/03-how-to-guides/**— also referenceasap-summary-ingest
Out of scope, needs a separate decision
asap-query-engine/src/precompute_engine/worker.rshas a real parsing path,deserialize_from_json_arroyo, plus tests asserting Arroyo-output equivalence. Removing Arroyo tooling doesn't automatically mean dropping this format support — decide separately.
🤖 Generated with Claude Code
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
refactor(rust): remove Flink/Arroyo/legacy-Kafka streaming engine sup…
refactor(asap-tools): remove Flink/Arroyo/legacy Kafka-ingest infrast…
docs: update architecture and how-to guides for Flink/Arroyo/Kafka re…
refactor(rust): remove Flink/Arroyo/legacy-Kafka streaming engine sup…
refactor(asap-tools): remove Flink/Arroyo/legacy Kafka-ingest infrast…
docs: update architecture and how-to guides for Flink/Arroyo/Kafka re…
refactor: remove Flink/Arroyo/legacy Kafka-ingest infra from asap-too…