Repository navigation
Revert sketchlib-rust path dependency once it is open sourced #154
Description
Context
`sketchlib-rust` (https://github.com/ProjectASAP/sketchlib-rust) is currently a private repo. As a temporary workaround, it is being vendored locally and rsynced to CloudLab nodes rather than fetched directly from GitHub by Cargo.
What was changed (and must be reverted)
-
`Utilities/components.conf` — added `sketchlib-rust` so it gets rsynced to nodes. Remove this line:
```
sketchlib-rust
``` -
`.gitignore` — added `sketchlib-rust/` to prevent committing the private source. Remove this entry once the repo is public.
-
Local clone at `asap-internal/sketchlib-rust/` — the repo source is vendored here. Delete it once the public repo is used directly.
Note: `QueryEngineRust/Cargo.toml` already uses the git dependency (PR ProjectASAP/asap-internal#434 kept/restored this). No change needed there.
Steps to revert
Once `ProjectASAP/sketchlib-rust` is made public:
- Remove `sketchlib-rust` from `Utilities/components.conf`
- Remove `sketchlib-rust/` from `.gitignore`
- Delete the local clone at `asap-internal/sketchlib-rust/`
- Regenerate `Cargo.lock` to pick up the latest public commit:
```bash
CARGO_NET_GIT_FETCH_WITH_CLI=true cargo generate-lockfile
```
Activity
milindsrivastava1997 commentedon Mar 4, 2026
PRO-440
milindsrivastava1997 commentedon Mar 4, 2026
Additional items to revert from PR ProjectASAP/asap-internal#434
PR ProjectASAP/asap-internal#434 added more temporary workarounds that also need to be reverted once sketchlib-rust is public:
QueryEngineRust/Dockerfile— remove thesketchlib-rustCOPY line:- COPY sketchlib-rust ./sketchlib-rustQueryEngineRust/Cargo.lock— after reverting Cargo.toml back to the git dependency, regenerate the lock file:milindsrivastava1997 commentedon Mar 4, 2026
CC @zzylol
milindsrivastava1997 commentedon Mar 4, 2026
Additional items to revert from PR ProjectASAP/asap-internal#434
PR ProjectASAP/asap-internal#434 added more temporary workarounds that also need to be reverted once sketchlib-rust is public:
QueryEngineRust/Dockerfile— remove thesketchlib-rustCOPY line, and revert theCargo.toml/Cargo.lockCOPY back to the original (which includedQueryEngineRust/Cargo.lock):Note: once sketchlib-rust is a git dependency again,
QueryEngineRust/Cargo.lockwill need to be regenerated and committed separately.QueryEngineRust/Cargo.lock— after reverting Cargo.toml back to the git dependency, regenerate the lock file. Since QueryEngineRust is part of the root workspace, the lock file lives at the repo root (/Cargo.lock), not insideQueryEngineRust/. The Dockerfile will need aQueryEngineRust-specific lock file only if it is removed from the workspace, otherwise just copy the rootCargo.lock.Revert sketchlib-rust path dependency workarounds now that repo is pu…
Revert sketchlib-rust path dependency workarounds now that repo is pu…