Repository navigation
Conversation
For Examples 1, 3a, 3b, 4a and 4b: plan the workload, start the data_plane binary against a Prometheus holding generated samples, Remote Write the same samples, and require every planned query to be answered by the plan with the Planner executor's result for the workload planned without ingestion-time state. Exact families must match exactly; Example 3a/4a's five-year KLL windows exceed k and KLL compaction is randomized, so they must agree within twice the 0.005 rank target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 5/5. Base: #821.
Before this PR
No test checked that the data plane's answers match the Planner's.
After this PR
data_plane/tests/e2e_examples.rsruns the realdata_planebinary for #509's PromQL Examples 1, 3a, 3b, 4a and 4b:Example 1 runs fully at query time; 3b and 4b use stored panes.
Examples 3a/4a match within a value tolerance of 10, about twice KLL's 0.005 rank error.
asap_sketchlib's KLL seeds its compaction from the thread RNG, so results abovekvary between runs. The other examples match exactly.Testing
cargo test -p data_plane --test e2e_examples(5 tests).🤖 Generated with Claude Code