Repository navigation
Conversation
Add a review-feedback section: the store-and-query baseline, freshness and detection-latency definitions, whole-system cost, bytes per stage, traffic scaling, a benchmark playground, and answers to the review's questions. Replace a person's name with the framework's name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first review of the three-pipeline demo asked for the trade-off, not only the sketch's cost. Computing in front of the database stores much less but drops the raw data; storing everything and querying later keeps it but costs storage, query CPU and freshness. RFC 0001 did not define freshness, did not count the log store's cost, and had no scaling or playground plan.
What
RFC 0001 gets a "Review feedback, 2026-10-19" section, marked as an update after approval, plus three inline update markers:
It also replaces a person's name in the throughput success criterion with "the OTAP benchmark framework".
How
Document only. Accepted RFCs are not rewritten (docs/rfcs/README.md), so the original text stays and the changes are additions marked as updates.
Before
After
Verification
asap-precompute-rs/src/otap/mod.rs(Summary data points withsketch.envelope) and the deploy configs (exporter:otlp_httpbetween stages).