fix(roster): require CheckAuth on getRosterList callback - #568
Open
Pajt9whauht283as wants to merge 1 commit into
Open
fix(roster): require CheckAuth on getRosterList callback#568Pajt9whauht283as wants to merge 1 commit into
Pajt9whauht283as wants to merge 1 commit into
Conversation
getRosterList was the only callback in roster.lua without an auth check, exposing full names, citizenids, callsigns, ranks, certifications and live radio channels to any player. Matches the pattern used by getOfficerTags, promoteOfficer, fireOfficer and updateOfficerCallsign. Closes Project-Sloth#566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing auth check to getRosterList, matching the pattern already used by every other callback in this file (getOfficerTags, promoteOfficer, ireOfficer, updateOfficerCallsign). Without it, any player can pull the full roster (names, citizenids, callsigns, ranks, certifications and live radio channels) regardless of MDT access.
Refs #566