Repository navigation
Conversation
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
|
Thanks for updating the CI versions! I checked the current matrix: Python 3.13 is already covered, but Python 3.12 and 3.13 are tested only with PyTorch 2.12.1. There isn't an explicit PR-test combination pairing either with the latest stable PyTorch, currently 2.15.0. Would it make sense to replace the redundant Python 3.11 / PyTorch 2.14.0 entry with 2.15.0, retain 2.14.1, and add Ubuntu entries for Python 3.12 and 3.13 with 2.15.0? That would also cover the README's current-plus-three-previous-minor-versions policy. Python 3.15 is included in release packaging and the classifiers, but still has no PR-test matrix entry. |
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
…nto 9058_update_ci_versions Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
|
@agourakis82 I've done that now and some other things, I think this addresses things. |
|
Thanks, looks good! The PyTorch sweep on 3.11 now covers the full support window. One small thing: 3.12 and 3.13 still only run against 2.12.1. Would adding a single Ubuntu entry for 3.12 (or 3.13) with 2.15.0 be worthwhile to catch issues with newer Python + latest PyTorch? Also a tiny nit: the commented |
|
@agourakis82 do you want to suggest a change in a comment I can then merge? This should give you credit on this PR as well. We can add one Py2.12 test for PyTorch 2.15 to the matrix. |
agourakis82
left a comment
There was a problem hiding this comment.
Here's the suggestion: one Python 3.12 + PyTorch 2.15.0 entry under Ubuntu, plus the small PYTHON_VER5 comment fix. Thanks!
Co-authored-by: Demetrios Chiuratto Agourakis <demetrios@agourakis.med.br> Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
|
Integrated now, thanks. If you have any ideas of what to do about failed jobs as they come up do let me know. |
Fixes part of #9058.
Description
This updates the version of Python and PyTorch MONAI is tested with to conform to our supported versions policy.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.