Skip to content

9058 Update CI Versions - #9266

Draft
ericspod wants to merge 8 commits into
Project-MONAI:devfrom
ericspod:9058_update_ci_versions
Draft

ericspod wants to merge 8 commits into
Project-MONAI:devfrom
ericspod:9058_update_ci_versions

Conversation

@ericspod

Copy link
Copy Markdown
Member

Fixes part of #9058.

Description

This updates the version of Python and PyTorch MONAI is tested with to conform to our supported versions policy.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Comment thread .github/workflows/ci_tests.yml Resolved
Comment thread .github/workflows/ci_tests.yml Resolved
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>

Copy link
Copy Markdown

Thanks for updating the CI versions! I checked the current matrix: Python 3.13 is already covered, but Python 3.12 and 3.13 are tested only with PyTorch 2.12.1. There isn't an explicit PR-test combination pairing either with the latest stable PyTorch, currently 2.15.0.

Would it make sense to replace the redundant Python 3.11 / PyTorch 2.14.0 entry with 2.15.0, retain 2.14.1, and add Ubuntu entries for Python 3.12 and 3.13 with 2.15.0? That would also cover the README's current-plus-three-previous-minor-versions policy. Python 3.15 is included in release packaging and the classifiers, but still has no PR-test matrix entry.

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
…nto 9058_update_ci_versions

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod

Copy link
Copy Markdown
Member Author

@agourakis82 I've done that now and some other things, I think this addresses things.

Copy link
Copy Markdown

Thanks, looks good! The PyTorch sweep on 3.11 now covers the full support window. One small thing: 3.12 and 3.13 still only run against 2.12.1. Would adding a single Ubuntu entry for 3.12 (or 3.13) with 2.15.0 be worthwhile to catch issues with newer Python + latest PyTorch? Also a tiny nit: the commented PYTHON_VER5 reads '3.14', probably meant '3.15'.

@ericspod

Copy link
Copy Markdown
Member Author

@agourakis82 do you want to suggest a change in a comment I can then merge? This should give you credit on this PR as well. We can add one Py2.12 test for PyTorch 2.15 to the matrix.

@github-project-automation github-project-automation Bot moved this to Not Yet Included in MONAI v1.7 Nov 10, 2026
@ericspod ericspod moved this from Not Yet Included to In progress in MONAI v1.7 Nov 10, 2026

@agourakis82 agourakis82 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the suggestion: one Python 3.12 + PyTorch 2.15.0 entry under Ubuntu, plus the small PYTHON_VER5 comment fix. Thanks!

Comment thread .github/workflows/ci_tests.yml Resolved
Comment thread .github/workflows/ci_tests.yml Resolved
Co-authored-by: Demetrios Chiuratto Agourakis <demetrios@agourakis.med.br>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod

Copy link
Copy Markdown
Member Author

Integrated now, thanks. If you have any ideas of what to do about failed jobs as they come up do let me know.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants