Cross-reference ruff/black/isort version pins between the two files - #9091
Cross-reference ruff/black/isort version pins between the two files#9091hjmjohnson wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughUpdated comments in Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This update improves discoverability between duplicated formatter and linter version pins without changing dependencies or pre-commit behavior. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description clearly explains the change, scope, testing, and lack of behavior changes. It omits the template headings, issue reference, and change-type checklist, but the required context is mostly complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
32644ef to
ae187f3
Compare
ruff, black and isort are each pinned twice: once in pyproject.toml's testing extra (the range a developer installs from) and once in .pre-commit-config.yaml (the exact rev pre-commit builds its environment from). Only black and isort carried a one-sided "keep synced" comment, in .pre-commit-config.yaml only; ruff had none anywhere. A contributor editing one pin had no in-file pointer to the other. Adds a same-line comment at each of the six pin sites naming the file holding its counterpart, so following either pin leads directly to the other. No version or behavior change. Signed-off-by: Hans Johnson <hans-johnson@uiowa.edu>
ae187f3 to
6eee69f
Compare
ruff, black and isort are each pinned twice: once in
pyproject.toml'stestingextra (the range a developer installs from) and once in.pre-commit-config.yaml(the exactrevpre-commit builds its environment from). Only black and isort carried a one-sided "keep synced" comment, in.pre-commit-config.yamlonly; ruff had none anywhere. A contributor editing one pin had no in-file pointer to the other.Adds a same-line comment at each of the six pin sites naming the file holding its counterpart. No version or behavior change — verified
pyproject.tomlstill parses as TOML and.pre-commit-config.yamlstill parses as YAML, andpre-commit run --all-filespasses with the tree unmodified.Independent of #9089 / #9090 — different lines, no overlap; can land in any order.