Skip to content

Cross-reference ruff/black/isort version pins between the two files - #9091

Open
hjmjohnson wants to merge 1 commit into
Project-MONAI:devfrom
BRAINSia:mono-lint-pin-cross-ref
Open

Cross-reference ruff/black/isort version pins between the two files#9091
hjmjohnson wants to merge 1 commit into
Project-MONAI:devfrom
BRAINSia:mono-lint-pin-cross-ref

Conversation

@hjmjohnson

Copy link
Copy Markdown
Contributor

ruff, black and isort are each pinned twice: once in pyproject.toml's testing extra (the range a developer installs from) and once in .pre-commit-config.yaml (the exact rev pre-commit builds its environment from). Only black and isort carried a one-sided "keep synced" comment, in .pre-commit-config.yaml only; ruff had none anywhere. A contributor editing one pin had no in-file pointer to the other.

Adds a same-line comment at each of the six pin sites naming the file holding its counterpart. No version or behavior change — verified pyproject.toml still parses as TOML and .pre-commit-config.yaml still parses as YAML, and pre-commit run --all-files passes with the tree unmodified.

Independent of #9089 / #9090 — different lines, no overlap; can land in any order.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: c012795a-956e-4798-8ba5-01150ae4ec4a

📥 Commits

Reviewing files that changed from the base of the PR and between 9ea04d4 and 32644ef.

📒 Files selected for processing (2)
  • .pre-commit-config.yaml
  • pyproject.toml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Updated comments in .pre-commit-config.yaml and pyproject.toml to document synchronization for Ruff, Black, and isort versions. Dependency versions and pre-commit hook behavior remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6eee6

This update improves discoverability between duplicated formatter and linter version pins without changing dependencies or pre-commit behavior. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: cross-referencing the Ruff, Black, and isort version pins in both files.
Description check ✅ Passed The description clearly explains the change, scope, testing, and lack of behavior changes. It omits the template headings, issue reference, and change-type checklist, but the required context is mostl…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the change, scope, testing, and lack of behavior changes. It omits the template headings, issue reference, and change-type checklist, but the required context is mostly complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hjmjohnson
hjmjohnson marked this pull request as ready for review September 3, 2026 15:10
@hjmjohnson
hjmjohnson force-pushed the mono-lint-pin-cross-ref branch from 32644ef to ae187f3 Compare September 3, 2026 15:13
ruff, black and isort are each pinned twice: once in pyproject.toml's
testing extra (the range a developer installs from) and once in
.pre-commit-config.yaml (the exact rev pre-commit builds its
environment from). Only black and isort carried a one-sided
"keep synced" comment, in .pre-commit-config.yaml only; ruff had
none anywhere. A contributor editing one pin had no in-file pointer
to the other.

Adds a same-line comment at each of the six pin sites naming the
file holding its counterpart, so following either pin leads
directly to the other. No version or behavior change.

Signed-off-by: Hans Johnson <hans-johnson@uiowa.edu>
@hjmjohnson
hjmjohnson force-pushed the mono-lint-pin-cross-ref branch from ae187f3 to 6eee69f Compare September 3, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant