Fix release verification harness - #12
Merged
Merged
Conversation
…se verification with the harness from main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Verify release run for 1.1.0 failed on Linux and Windows before testing anything.
npm pack --pack-destinationrequires the destination folder to exist, andscripts/package-smoke.mjs --from-registrynever created it.npm pack.v1.1.0tag contains the buggy script, and the package under test comes from the registry, pinned by the tested integrity. The now-redundant tag-vs-package.json check is dropped.Evidence: with this fix,
node scripts/package-smoke.mjs --from-registry @programcomputer/nasa-mcp-server@1.1.0 --expect-integrity sha512-iMX4…Fg==passes locally on Windows. It downloads with a fresh cache, integrity matches, installs runtime dependencies only, the bin reports 1.1.0, and 5/5 stdio/HTTP MCP tests pass against the installed bin. No package code changes.