Enhance usage examples#45
Merged
Merged
Conversation
ondrejkrejci
requested changes
Jun 9, 2026
ondrejkrejci
left a comment
ondrejkrejci
left a comment
Contributor
There was a problem hiding this comment.
One change, then it is good to go.
| lower_atoms = [] | ||
| lower_coefs = [] | ||
| work_function = -7.5 | ||
| work_function_decay = 1000.0 # py orb has WF of -12.5; s has WF -2.5 eV |
Contributor
There was a problem hiding this comment.
This should be then changed to 0.0 as it is not doing anything for 'states'
Contributor
There was a problem hiding this comment.
Good morning! Ideal it would be to remove the comment as well. Thank you!
Contributor
Author
There was a problem hiding this comment.
Good morning, done
1 task
Set work function decay to zero in demonstration scripts for the dIdV and states scan types.
GianmarcoMidena
force-pushed
the
enhance-usage-examples
branch
from
b3b24a2 to
b339e4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: