Skip to content

Fix the error response model #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbrassel merged 1 commit into from
Jul 22, 2026
Merged

Fix the error response model #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions flame_hub/_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
from json import JSONDecodeError

import httpx2 as httpx
from pydantic import ValidationError, BaseModel, ConfigDict
from pydantic import ValidationError, BaseModel, ConfigDict, Field, AliasChoices


class ErrorResponse(BaseModel):
model_config = ConfigDict(extra="allow")
"""Configuration so that extra properties may be available."""
name: str
"""Name of the error."""
code: str
"""Name of the error code."""
status_code: int
status_code: int | None = Field(validation_alias=AliasChoices("status_code", "statusCode"), default=None)
"""HTTP code of the response."""
message: str
"""The error message."""
Expand Down Expand Up @@ -67,7 +65,10 @@ def new_hub_api_error_from_response(r: httpx.Response) -> HubAPIError:
error_message = f"received status code {r.status_code}"

try:
error_response = ErrorResponse(**({"status_code": r.status_code} | r.json()))
error_response = ErrorResponse(**r.json())
# Sometimes the status code is not part of the payload.
if error_response.status_code is None:
error_response.status_code = r.status_code
error_message = f"received status code {error_response.status_code} ({error_response.code}): "

if error_response.message.strip() == "":
Expand Down