Trilogy NTSC CElementGen by henriquegemignani · Pull Request #870 · PrimeDecomp/prime

henriquegemignani · 2026-10-15T08:56:17Z

No description provided.

decomp-dev · 2026-10-15T08:59:42Z

Report for R3IJ01_00 (`65efe58` - `1ac86c0`)

No changes

Report for R3ME01_00 (`65efe58` - `1ac86c0`)

📈 Matched code: 4.26% (+0.29%, +13320 bytes)
📈 Matched data: 3.39% (+0.02%, +280 bytes)

✅ 58 new matches

Unit	Item	Bytes	Before	After
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderParticlesIndirectTexture()`	+2908	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::UpdateExistingParticles()`	+1148	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderBasicParticlesRotNoTS(const CTransform4f&)`	+492	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::~CElementGen()`	+432	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`void rstl::sort<CElementGen::CTexturedParticleListItem, CTexturedParticleListItemViewPointComp>(CElementGen::CTexturedParticleListItem, CElementGen::CTexturedParticleListItem*, CTexturedParticleListItemViewPointComp)`	+424	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::UpdateVelocitySource(int, int, CElementGen::CParticle&)`	+408	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::UpdateAdvanceAccessParameters(int, int)`	+396	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`void rstl::sort<CElementGen::CParticleListItem, CParticleListItemViewPointComp>(CElementGen::CParticleListItem, CElementGen::CParticleListItem*, CParticleListItemViewPointComp)`	+396	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::ConstructChildParticleSystem(TToken<CGenDescription>) const`	+392	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderBasicParticlesRotTS(const CTransform4f&)`	+392	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderBasicParticlesNoRotNoTS(const CTransform4f&)`	+384	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::SetTranslation(const CVector3f&)`	+372	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`void rstl::__sort3<CElementGen::CTexturedParticleListItem, CTexturedParticleListItemViewPointComp>(CElementGen::CTexturedParticleListItem&, CElementGen::CTexturedParticleListItem&, CElementGen::CTexturedParticleListItem&, CTexturedParticleListItemViewPointComp)`	+348	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::Render()`	+300	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`void rstl::__sort3<CElementGen::CParticleListItem, CParticleListItemViewPointComp>(CElementGen::CParticleListItem&, CElementGen::CParticleListItem&, CElementGen::CParticleListItem&, CParticleListItemViewPointComp)`	+296	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`rstl::vector<CElementGen::CParticle, rstl::rmemory_allocator>::reserve(int)`	+292	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderBasicParticlesNoRotTS(const CTransform4f&)`	+284	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::UpdateLightParameters()`	+268	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`rstl::vector<CElementGen::CAdvancedValues, rstl::rmemory_allocator>::reserve(int)`	+244	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::Update(double)`	+236	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`void rstl::__insertion_sort<CElementGen::CTexturedParticleListItem, CTexturedParticleListItemViewPointComp>(CElementGen::CTexturedParticleListItem, CElementGen::CTexturedParticleListItem*, CTexturedParticleListItemViewPointComp)`	+212	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`void rstl::__insertion_sort<CElementGen::CParticleListItem, CParticleListItemViewPointComp>(CElementGen::CParticleListItem, CElementGen::CParticleListItem*, CParticleListItemViewPointComp)`	+188	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::DestroyParticles()`	+184	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::GetSystemCount()`	+176	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::SetGeneratorRate(float)`	+176	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::EndLifetime()`	+172	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::SetOrientation(const CTransform4f&)`	+164	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::IsSystemDeletable() const`	+160	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::GetParticleCountAllInternal() const`	+156	0.00%	100.00%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`.bss`	+152	0.00%	100.00%

...and 28 more new matches

📈 19 improvements in unmatched items

Unit	Item	Bytes	Before	After
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderParticles()`	+7140	0.00%	98.96%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderModels()`	+3104	0.00%	99.76%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::CElementGen(TToken<CGenDescription>, CElementGen::EModelOrientationType, CElementGen::EOptionalSystemFlags)`	+2682	0.00%	98.34%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::UpdateChildParticleSystems(double)`	+2269	0.00%	99.55%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderLines()`	+2088	0.00%	99.85%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::RenderParticlesFlameThrower(CElementGen* const*, int)`	+1708	0.00%	97.27%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::CreateNewParticles(int)`	+1466	0.00%	99.93%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::InternalUpdate(double)`	+1133	0.00%	96.40%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::BuildParticleSystemBounds()`	+670	0.00%	98.68%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::GetLight() const`	+632	0.00%	99.37%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::SetGlobalScale(const CVector3f&)`	+205	0.00%	96.87%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::SetLocalScale(const CVector3f&)`	+205	0.00%	96.87%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::UpdatePSTranslationAndOrientation()`	+194	0.00%	97.44%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`.rodata`	+188	0.00%	78.48%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`rstl::vector<CMatrix3f, rstl::rmemory_allocator>::reserve(int)`	+127	0.00%	88.89%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`CElementGen::AccumulateBounds(const CVector3f&, float)`	+124	0.00%	97.03%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`.sdata2`	+61	0.00%	96.77%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`.sbss`	+13	0.00%	84.62%
`rs5mp1_p/Kyoto/Particles/CElementGen`	`.sdata`	+3	0.00%	40.00%

Report for GM8E01_02 (`65efe58` - `1ac86c0`)

No changes

Report for GM8J01_00 (`65efe58` - `1ac86c0`)

📈 1 improvement in an unmatched item

Unit	Item	Bytes	Before	After
`main/Kyoto/Particles/CElementGen`	`CElementGen::RenderParticles()`	+74	98.88%	99.98%

Report for R3MP01_00 (`65efe58` - `1ac86c0`)

No changes

Report for GM8E01_48 (`65efe58` - `1ac86c0`)

No changes

Report for GM8J01_DD (`65efe58` - `1ac86c0`)

📈 1 improvement in an unmatched item

Unit	Item	Bytes	Before	After
`main/Kyoto/Particles/CElementGen`	`CElementGen::RenderParticles()`	+74	98.88%	99.98%

Report for GM8E01_01 (`65efe58` - `1ac86c0`)

No changes

Report for GM8P01_00 (`65efe58` - `1ac86c0`)

📈 1 improvement in an unmatched item

Unit	Item	Bytes	Before	After
`main/Kyoto/Particles/CElementGen`	`CElementGen::RenderParticles()`	+74	98.88%	99.98%

Report for GM8E01_00 (`65efe58` - `1ac86c0`)

No changes

Report for GM8EAB_00 (`65efe58` - `1ac86c0`)

No changes

henriquegemignani added 16 commits October 15, 2026 10:33

Start Trilogy CElementGen

9ed99e8

Trilogy CElementGen dtor and mHasVMD layout

c8d07f8

Trilogy CElementGen scope guard, assign and symbol names

8063fc2

Unchecked Wii rstl vector push_back

8bccb96

Trilogy CElementGen Render restore and GetLight colors

d299ede

Trilogy CStopwatch elapsed time form

4d85aa0

Trilogy CElementGen indirect texture loop

9f3562f

Trilogy CElementGen rotated particle view point

b75eb26

Copying rstl pointer_iterator arithmetic

36d613a

Trilogy CGraphics SetAlphaCompare thunk

da7772b

Trilogy CGraphics kEnvModulate symbol

dfc9854

Trilogy CElementGen oriented particle locals

7f41fe0

Guard Wii-only rstl iterator and CElementGen locals

63cafad

Trilogy CElementGen particle word copies

24d87c6

Trilogy CElementGen flamethrower texture loop

9e13ff1

Share CParticle word-copy unions with GC

1ac86c0

Antidote merged commit 6d3b814 into main Oct 15, 2026
11 checks passed

Antidote deleted the claude/trilogy-ntsc-celementgen-7d56a6 branch October 15, 2026 11:51

Navigation Menu

Repository navigation

Trilogy NTSC CElementGen - #870

Trilogy NTSC CElementGen#870
Antidote merged 16 commits into
mainfrom
claude/trilogy-ntsc-celementgen-7d56a6

henriquegemignani commented Oct 15, 2026

Uh oh!

decomp-dev Bot commented Oct 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

henriquegemignani commented Oct 15, 2026

Uh oh!

decomp-dev Bot commented Oct 15, 2026

Report for R3IJ01_00 (65efe58 - 1ac86c0)

No changes

Report for R3ME01_00 (65efe58 - 1ac86c0)

Report for GM8E01_02 (65efe58 - 1ac86c0)

No changes

Report for GM8J01_00 (65efe58 - 1ac86c0)

Report for R3MP01_00 (65efe58 - 1ac86c0)

No changes

Report for GM8E01_48 (65efe58 - 1ac86c0)

No changes

Report for GM8J01_DD (65efe58 - 1ac86c0)

Report for GM8E01_01 (65efe58 - 1ac86c0)

No changes

Report for GM8P01_00 (65efe58 - 1ac86c0)

Report for GM8E01_00 (65efe58 - 1ac86c0)

No changes

Report for GM8EAB_00 (65efe58 - 1ac86c0)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Report for R3IJ01_00 (`65efe58` - `1ac86c0`)

Report for R3ME01_00 (`65efe58` - `1ac86c0`)

Report for GM8E01_02 (`65efe58` - `1ac86c0`)

Report for GM8J01_00 (`65efe58` - `1ac86c0`)

Report for R3MP01_00 (`65efe58` - `1ac86c0`)

Report for GM8E01_48 (`65efe58` - `1ac86c0`)

Report for GM8J01_DD (`65efe58` - `1ac86c0`)

Report for GM8E01_01 (`65efe58` - `1ac86c0`)

Report for GM8P01_00 (`65efe58` - `1ac86c0`)

Report for GM8E01_00 (`65efe58` - `1ac86c0`)

Report for GM8EAB_00 (`65efe58` - `1ac86c0`)