Repository navigation
Preserve CR-only line endings when formatting files - #2234
Merged
Christoph Bergmeister (bergmeister) merged 3 commits intoOct 23, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment for pull request 2230
Preserve CR-only line endings when formatting files
Oct 23, 2026
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes consistently handle CR-only lines and include regression coverage, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes CR-only line handling so the formatter can infer indentation correctly and preserve those line endings when formatting files.
Changes:
- Recognizes CRLF, CR, and LF separators through the shared line-splitting helper.
- Uses that helper for indentation inference.
- Adds an in-place CR-only regression test and makes the legacy-encoding fixture independent of the test file’s encoding.
| File | Description |
|---|---|
| Tests/Engine/InvokeFormatter.tests.ps1 | Verifies CR-only formatting output and saved contents; updates the legacy-encoding fixture. |
| Engine/Extensions.cs | Splits text on CRLF, CR, or LF. |
| Engine/Commands/InvokeFormatterCommand.cs | Uses shared line splitting for indentation inference. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2235
October 23, 2026 17:45
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 23, 2026 17:45
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 23, 2026 17:45
Christoph Bergmeister (bergmeister)
merged commit Oct 23, 2026
ae4cac8
into
copilot/add-path-parameter-to-invoke-formatter
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-code-review-comment-2230
branch
October 23, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CR-only scripts could fail during indentation inference because parser line numbers were matched against LF-only splits. The formatter also needs to retain CR-only separators throughout edits.