Skip to content

Add 0.2.0 to 0.2.1 update script and adopt stable - #9

Merged
jnasbyupgrade merged 1 commit into
masterfrom
fix-language-get-debug
Oct 27, 2026
Merged

jnasbyupgrade merged 1 commit into
masterfrom
fix-language-get-debug

Conversation

@jnasbyupgrade

@jnasbyupgrade jnasbyupgrade commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Adds the missing 0.2.0--0.2.1 update script so a 0.2.0 install can ALTER EXTENSION trunklet UPDATE through the whole chain, and adopts the stable pseudo-version (default_version = 'stable') between releases.

Fixes #7

The update script creates _trunklet.template__get(template_id, ...), process(template_id, ...) and the execute_into*/execute_text* families, and replaces process_language() and the process(name, version, ...) function with their 0.2.1 bodies. The anyarray overloads of process()/process_language() are commented out in the 0.2.0 install script, so there is nothing to drop; nothing in trunklet-format 0.2.0 depends on them (it calls process_language() with jsonb).

One commit: it adopts stable (control file, 0.3.3--stable update script, HISTORY.asc STABLE section; sql/trunklet--stable.sql stays generated and gitignored), adds the update script, the committed trunklet--0.2.0.sql and trunklet--0.2.1.sql (byte-identical to upstream/0.2.0 and upstream/0.2.1 sql/trunklet.sql), and adds test/sql/update.sql. That test installs 0.2.0 with a stored language and template, updates to stable, checks the template still processes and the 0.2.1 functions exist, and compares extension members and pg_get_functiondef() output of updated installs (from 0.2.0, 0.2.1, 0.2.1 updated to 0.3.2, and 0.3.3 with the pre-fix language__get()) against a fresh stable install. make verify-results passes on PG12 and PG17; with the update script gutted, or with the language__get() fix below reverted, the new test fails.

The one difference between an updated install and a fresh one was _trunklet.language__get(varchar): a fresh 0.3.3 install has its RAISE DEBUG 'language__get(%)' line (added to trunklet.sql in a22c416), but trunklet--0.3.2--0.3.3.sql never carried it. 0.3.3--stable now redefines the function, covering installs already at 0.3.3, and the same definition is added retroactively to the released 0.3.2--0.3.3 script so installs updating through it match too. It only affects RAISE DEBUG output, with no behavior change.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2285fad4-6b29-4119-b1a6-7f6e31931b33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jnasbyupgrade
jnasbyupgrade force-pushed the master branch 3 times, most recently from cf25b79 to 55eac10 Compare October 26, 2026 21:20
@jnasbyupgrade
jnasbyupgrade force-pushed the fix-language-get-debug branch from 2c03acc to d04a5da Compare October 26, 2026 21:27
@jnasbyupgrade jnasbyupgrade changed the title Carry language__get() change in 0.3.2--0.3.3 update script Add 0.2.0 to 0.2.1 update script and adopt stable Oct 26, 2026
Comment thread HISTORY.asc Outdated

0.3.3
-----
=== Include `language__get()` debug message in the 0.3.2 to 0.3.3 update script

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't actually put this here. 0.3.3 is already out. We should mention it under stable, both that we update it in stable and that we've retroactively added it to the previously released 0.3.2--0.3.3.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude here: fixed in e8e7578. The note is now under STABLE and says 0.3.3--stable adds the language__get() debug message and that it was retroactively added to the already-released 0.3.2--0.3.3 update script.

Comment thread sql/trunklet--0.3.3--stable.sql Outdated
@jnasbyupgrade
jnasbyupgrade marked this pull request as ready for review October 26, 2026 22:46
@jnasbyupgrade
jnasbyupgrade force-pushed the fix-language-get-debug branch from d04a5da to e8e7578 Compare October 26, 2026 22:52
jnasbyupgrade added a commit that referenced this pull request Oct 27, 2026
Records only trunklet's step-1 exceptions to the shared release process
(releases 0.0.1 through 0.3.3 are branches, not tags; the late-added
0.2.0, 0.2.1 and 0.3.3 install scripts) and links to
[`ai/RELEASE.md`](https://github.com/Postgres-Extensions/ai/blob/main/RELEASE.md)
for everything else.

Depends on #9 for the `sql/trunklet--0.2.0.sql` and
`sql/trunklet--0.2.1.sql` install scripts.
Adds the missing `0.2.0--0.2.1` update script so a 0.2.0 install can
`ALTER EXTENSION trunklet UPDATE` through the whole chain, and adopts
the `stable` pseudo-version (`default_version = 'stable'`) between
releases.

The `language__get()` debug message that a fresh 0.3.3 install has is
now added by `0.3.3--stable` (for installs already at 0.3.3) and
retroactively by the released `0.3.2--0.3.3` update script.

Fixes #7
@jnasbyupgrade
jnasbyupgrade force-pushed the fix-language-get-debug branch from e8e7578 to 8615d9c Compare October 27, 2026 16:29
@jnasbyupgrade
jnasbyupgrade merged commit 40e4b89 into master Oct 27, 2026
14 checks passed
@jnasbyupgrade
jnasbyupgrade deleted the fix-language-get-debug branch October 27, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No update path from trunklet 0.2.0 (or 0.2.1) to later versions

1 participant