Repository navigation
Add 0.2.0 to 0.2.1 update script and adopt stable - #8
Merged
Merged
Conversation
Set `default_version = 'stable'` in `trunklet.control` and add the `0.3.3--stable` no-op update script placeholder, so a fresh checkout is always ready to cut the next release. `sql/trunklet--stable.sql` stays generated and gitignored. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Without a `0.2.0--0.2.1` script, `ALTER EXTENSION trunklet UPDATE` had no path from 0.2.0 to any later version. The script creates `_trunklet.template__get(template_id, ...)`, `process(template_id, ...)` and the `execute_into*`/`execute_text*` families, and replaces `process_language()` and `process()` with their 0.2.1 bodies. Commit the shipped 0.2.0 and 0.2.1 install scripts so the path can be tested, and add `test/sql/update.sql`, which installs 0.2.0 with a stored language and template and updates to `stable`. Fixes #7 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
jnasbyupgrade
marked this pull request as ready for review
October 26, 2026 20:45
jnasbyupgrade
added a commit
that referenced
this pull request
Oct 26, 2026
Adds the missing `0.2.0--0.2.1` update script so a 0.2.0 install can `ALTER EXTENSION trunklet UPDATE` through the whole chain, and adopts the `stable` pseudo-version (`default_version = 'stable'`) between releases. Fixes #7 The `0.3.3--stable` script also restores the `RAISE DEBUG` line in `_trunklet.language__get(varchar)` that updates from 0.2.x lacked.
jnasbyupgrade
added a commit
that referenced
this pull request
Oct 26, 2026
Adds the missing `0.2.0--0.2.1` update script so a 0.2.0 install can `ALTER EXTENSION trunklet UPDATE` through the whole chain, and adopts the `stable` pseudo-version (`default_version = 'stable'`) between releases. The 0.3.2--0.3.3 update script now also carries the `language__get()` debug message that a fresh 0.3.3 install has, and `test/sql/update.sql` compares updated installs against a fresh one. Fixes #7
jnasbyupgrade
added a commit
that referenced
this pull request
Oct 26, 2026
Adds the missing `0.2.0--0.2.1` update script so a 0.2.0 install can `ALTER EXTENSION trunklet UPDATE` through the whole chain, and adopts the `stable` pseudo-version (`default_version = 'stable'`) between releases. The `language__get()` debug message that a fresh 0.3.3 install has is now added by `0.3.3--stable` (for installs already at 0.3.3) and retroactively by the released `0.3.2--0.3.3` update script, and `test/sql/update.sql` compares updated installs against a fresh one. Fixes #7
jnasbyupgrade
added a commit
that referenced
this pull request
Oct 27, 2026
Adds the missing `0.2.0--0.2.1` update script so a 0.2.0 install can `ALTER EXTENSION trunklet UPDATE` through the whole chain, and adopts the `stable` pseudo-version (`default_version = 'stable'`) between releases. The `language__get()` debug message that a fresh 0.3.3 install has is now added by `0.3.3--stable` (for installs already at 0.3.3) and retroactively by the released `0.3.2--0.3.3` update script. Fixes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing
0.2.0--0.2.1update script so a 0.2.0 install canALTER EXTENSION trunklet UPDATEthrough the whole chain, and adopts thestablepseudo-version (default_version = 'stable') between releases.Fixes #7
The update script creates
_trunklet.template__get(template_id, ...),process(template_id, ...)and theexecute_into*/execute_text*families, and replacesprocess_language()and theprocess(name, version, ...)function with their 0.2.1 bodies. Theanyarrayoverloads ofprocess()/process_language()are commented out in the 0.2.0 install script, so there is nothing to drop; nothing intrunklet-format0.2.0 depends on them (it callsprocess_language()withjsonb).Two commits: the first adopts
stable(control file, no-op0.3.3--stableplaceholder,HISTORY.ascSTABLE section;sql/trunklet--stable.sqlstays generated and gitignored), the second adds the update script, the committedtrunklet--0.2.0.sqlandtrunklet--0.2.1.sql(byte-identical toupstream/0.2.0andupstream/0.2.1sql/trunklet.sql), andtest/sql/update.sql, which installs 0.2.0 with a stored language and template, updates tostable, and checks the template still processes and the 0.2.1 functions exist.make verify-resultspasses on PG12 and PG17; with the update script gutted the new test fails.Verified separately on PG12 and PG17 by comparing
ALTER EXTENSION UPDATEresults against fresh installs: 0.2.0 updated to 0.2.1 has identical extension member objects (ACLs, function bodies) andpg_dump -soutput to a fresh 0.2.1 install, and the stored language and template survive. 0.2.0 updated tostablehas identicalpg_dump -soutput to a freshstableinstall, with one pre-existing difference unrelated to this PR: the update chain leaves_trunklet.language__get(varchar)without aRAISE DEBUGline that a fresh 0.3.3 install has (the same result when starting from 0.2.1).