Repository navigation
Conversation
Add class-level docstring and per-method docstrings to ExceptionCapture, covering __init__, close, exception_handler, thread_exception_handler, exception_receiver, and capture_exception. No behaviour changes — documentation only. Signed-off-by: mi-vault <asmisharma2026@gmail.com>
marandaneto
reviewed
Nov 16, 2026
marandaneto
left a comment
Member
There was a problem hiding this comment.
Agent-drafted and reviewed by Manoel.
Signed-off-by: mi-vault <asmisharma2026@gmail.com>
marandaneto
approved these changes
Nov 16, 2026
marandaneto
left a comment
Member
There was a problem hiding this comment.
Agent-drafted and reviewed by Manoel.
Thanks for addressing the feedback. The bucket_size docstring now describes it as token capacity, and the exception_receiver docstring no longer claims the Django/Flask integrations use it. LGTM.
marandaneto
enabled auto-merge (squash)
November 16, 2026 10:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
ExceptionCaptureis the class responsible for installing and managing process-widesys.excepthookandthreading.excepthookhandlers that forward uncaught exceptions to PostHog. Its public methods (__init__,close,exception_handler,thread_exception_handler,exception_receiver, andcapture_exception) had no docstrings, making it harder for contributors and integrators to understand the intent, parameters, and behaviour of each method without reading through the implementation.This PR adds:
ExceptionCapturedoes and its two optional features (hook chaining and rate limiting)__init__docstring covering all five parameters with their clamping constraints and defaultsclose,exception_handler,thread_exception_handler,exception_receiver, andcapture_exceptionNo behaviour changes; documentation only.
How did you test it?
Existing test suite (
pytest --verbose --timeout=30) passes without modification. No new tests are needed as this is a documentation-only change.Verified with:
ruff format --check .(clean)ruff check .(clean)Checklist
Agent Context