Repository navigation
feat(replay): raise native floors for session replay v2 trigger groups - #648
Draft
marc-merino wants to merge 3 commits into
Draft
marc-merino wants to merge 3 commits into
marc-merino wants to merge 3 commits into
Conversation
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
marandaneto
marked this pull request as draft
October 21, 2026 08:42
Member
|
draft until native versions are released |
The native SDKs evaluate the v2 trigger groups, so raise the floors to posthog-android 3.73.0 and posthog-ios 3.91.0, the first releases that support them. Assisted-by: Claude Code/claude-opus-5-5
marc-merino
force-pushed
the
knit/session-replay-v2-trigger-groups-on-mobile
branch
from
October 25, 2026 20:29
8b50a5c to
3379ebb
Compare
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
…sion-replay-v2-trigger-groups-on-mobile Conflicts in the three native floor declarations resolved to main's floors (posthog-android 3.77.0, posthog-ios 3.92.3). The next commit raises them again to the releases that will carry v2 trigger groups. Co-Authored-By: Ivaldi <ivaldi@users.noreply.github.com>
…y v2 trigger groups main moved the floors past the ones this branch had picked, to releases that still lack v2 trigger groups. The support ships in the next minor of each native SDK, so the floors are now posthog-android 3.78.0 (main is at 3.77.1) and posthog-ios 3.98.0 (main is at 3.97.2), and the changeset names the same versions. These releases do not exist yet: the Android and iOS builds cannot resolve them until the native PRs are merged and released. Co-Authored-By: Ivaldi <ivaldi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knit Bundle
View bundle
This PR is part of Knit bundle
session-replay-v2-trigger-groups-on-mobile.See the other review objects in this bundle:
posthog-ios: feat(replay): support session replay v2 trigger groups posthog-ios#921posthog-android: feat(replay): support session replay v2 trigger groups posthog-android#850posthog-flutter: feat(replay): raise native floors for session replay v2 trigger groups #648 (this PR)posthog-js: feat(react-native): support session replay v2 trigger groups posthog-js#5239Bundle id:
session-replay-v2-trigger-groups-on-mobileBundle title: Session replay v2 trigger groups on mobile
💡 Motivation and Context
Closes #545.
Flutter session replay runs on the native SDKs: Dart captures go through the native capture pipeline, and posthog-android / posthog-ios fetch the remote config and decide whether to record. So once the native SDKs evaluate v2 trigger groups, Flutter apps get them without Dart changes. This PR only raises the native floors to the releases that will contain that support:
[3.73.0,4.0.0)>= 3.91.0(podspec andPackage.swift)Merge order: this can only merge after the Android and iOS PRs (linked in the Knit block above) are released. Until then the Android and iOS builds here can't resolve those versions, so CI is expected to fail. If the native releases ship under different version numbers, I'll update the floors. The example apps'
Package.resolvedfiles are left as they are until the iOS release exists.💚 How did you test it?
There is no Dart or plugin code change. The trigger-group behaviour itself is tested in the native PRs: unit tests, plus end-to-end runs of the Android sample and the iOS example app against a mock server. Once the native releases exist I'll run the Flutter example on Android and iOS against the same mock and post the results here.
📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)