Repository navigation
feat(error-tracking): send in-app rules for server-side reclassification - #983
Closed
marandaneto wants to merge 1 commit into
Closed
marandaneto wants to merge 1 commit into
marandaneto wants to merge 1 commit into
Conversation
marandaneto
requested review from
a team,
JamesPatrickGill,
ablaszkiewicz and
hpouillot
November 16, 2026 11:42
Contributor
posthog-android Compliance ReportDate: 2026-11-16 11:44:18 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Member
Author
|
Tracking issue with a longer-term alternative (in-app rules stored on the release at ProGuard upload): PostHog/posthog#136478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
On minified (R8/ProGuard) builds,
inAppIncludesandinAppExcludesare matched against obfuscated class names, so they rarely match. After deobfuscation the server only promotes frames under theapplicationId, so:com.myapp.vendoredis overridden and those frames still show as in-appapplicationId, such as a shared library module, is never appliedThis PR sends the configured rules with the exception so the server can apply them again to the deobfuscated class names:
$exception_in_app_includes$exception_in_app_excludesThey are only sent when frames carry a
map_id, which meansreleaseIdentifieris set. Without one there is no deobfuscation, so the SDK's classification is final.Server-side counterpart: PostHog/posthog#136364. This PR has no effect until that one ships, and the server ignores these properties until then.
💚 How did you test it?
ThrowableCoercerTestcases: the rules are sent when amap_idis present, and left out when there is nomap_idor no rules.spotlessCheck,:posthog:apiCheckand theThrowableCoercerTestandPostHogTestsuites locally. Did not test end to end against a minified app.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi coding agent with Claude Opus. The human chose sending the rules over two alternatives: a per-frame "excluded" marker, which fixes excludes only, and sending no value for unknown frames, which the server reads as
true. No sdk-specs spec covers in-app classification.