Repository navigation
fix: release review follow-ups for posthog-android 4.0 - #976
Merged
turnipdabeets merged 3 commits intoNov 12, 2026
Merged
Conversation
The reference generator read docs/migration-*.md, which the 4.0 branch no longer has since the guide moved to MIGRATION.md, so a release kept the old generated page. That page now becomes the Android migration guide on posthog.com, so read MIGRATION.md and regenerate it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since the core-to-android constraint, core 7.0 or posthog-server 2.25 next to posthog-android 3.x resolves posthog-android 4.0 instead of failing at runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… flake The two personless dedup tests dropped every event in beforeSend, so no hash was ever stored and they passed with personless detection switched off. They now queue events to a mock server, and fail under that mutation. The HTTP-date Retry-After test compared against the real clock, so it read 19 instead of 20 when the request crossed a second boundary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
Contributor
posthog-android Compliance ReportDate: 2026-11-12T19:56:43.970564+00:00 ✅ All Tests Passed!232/232 tests passed Capture_V1 Tests✅ 105/105 tests passed View Details
Capture_Ai_V1 Tests✅ 110/110 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
PR overviewNo security issues were found in this pull request. Reviews
|
There was a problem hiding this comment.
Approved.
Contained documentation-generation and test changes; no runtime SDK, dependency, or deployment behavior changes and no outstanding review concerns.
- Author wrote 12% of the modified lines and has 38 merged PRs in these paths (familiarity MODERATE).
- PostHog Review (Standard) reviewed the current head: no findings.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 13L, 1F substantive, 160L/6F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (160L, 6F, cross-cutting, fix) |
| stamphog 2.8.0 | .stamphog/policy.yml @ 3d2ae17 · reviewed head 3d2ae17 |
3 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Stacked on #871. Three problems found in a release review of the 4.0 branch.
The migration guide page on posthog.com would stay stale.
bin/docs_scripts/generate_markdown.pybuiltreferences/posthog-android-migration.mdfromdocs/migration-*.md. The 4.0 guide moved toMIGRATION.md, so no file matched and the release kept the old generated page. That page was 116 lines behindMIGRATION.mdand linked/docs/libraries/capture-v1, which PostHog/posthog.com#21385 removes. PostHog/posthog.com#22061, which #21385 is stacked on, turns/docs/libraries/androidinto the generated reference and adds this page to the nav as the Android migration guide, so it's the upgrade guide users will read. The generator now readsMIGRATION.md, drops its# Migration guidetitle (the front matter supplies one) and the page is regenerated. Its body is identical toMIGRATION.md.The guide was wrong about mixing versions after #974. It said
posthog-server2.25 next toposthog-android3.x fails at runtime. With #974's constraint, Gradle resolvesposthog-android4.0 instead. The "Requirements and versions" paragraph, theposthog-serversection and the server changeset now say that. The paragraph also says a library compiled against 3.x still fails at runtime: a Flutter app onposthog_flutter5.60.2 plus core 7 builds, because the plugin compiles in its own Gradle project against 3.x, and then calls removed APIs (PostHogOnFeatureFlags,RRStyle).Two personless dedup tests stopped testing anything after the
mainmerge. Since #967 the person properties hash is stored only once an event is queued.PostHogCaptureOptionsTest's defaultbeforeSenddrops every event, so no hash was ever stored, and the tests passed with personless detection switched off. They now queue events to a mock server.Also fixes a flaky
PostHogCaptureV1Testcase: the HTTP-dateRetry-Aftertest compared against the real clock, and read 19 instead of 20 whenever the request crossed a second boundary.💚 How did you test it?
Generator: ran the migration step locally. The page body matches
MIGRATION.mdline for line.MIGRATION.mdhas no repo-relative links, so they all work on posthog.com.Version mixing: published core
7.0.0,posthog-android4.0.0andposthog-server2.25.0from feat!: posthog-android 4.0 and posthog 7.0 #871's head to a scratch Maven repo, then resolved a throwaway AGP 8.9.1 app:posthog-android:3.76.2+posthog-server:2.25.0posthog-android4.0.0posthog-android:[3.75.0,4.0.0)+posthog:7.0.0posthog-android4.0.0posthog-android:3.76.2onlyTests: with personless detection switched off (
surelyProcessesPersonProfilereturningtrueand the queued check ignoringprocess_person_profile), the two tests now fail, 2 of 18. Before this change they passed. With the code restored,PostHogCaptureOptionsTestandPostHogCaptureV1Testpass, andspotlessCheckpasses. The full:posthog:testrun's only failure was theRetry-Afterflake this PR fixes.📝 Checklist
If releasing new changes
.changeset/server-keep-on-feature-flags.mdentry.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Opus 5.5) found these in a release review of #871 and made the fixes. I pointed the generator at
MIGRATION.mdinstead of moving the guide back todocs/, because the changesets, README and the docs PRs linkMIGRATION.md. The generator change only touches the migration step, so regenerating it didn't need Dokka or rewrite the 3.x reference.🤖 Generated with Claude Code