Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| @@ -252,8 +261,7 @@ def main() -> None: | |||
| if not opts.experimental: | |||
| write("posthog-android-reference.md", [front_matter("PostHog Android SDK", body), *body]) | |||
| if guides := sorted((ROOT / "docs").glob("migration-*.md"), reverse=True): | |||
Contributor
There was a problem hiding this comment.
[suggestion] We glob docs/migration-*.md, but the guide lives at the root MIGRATION.md (the one #973 edits), so guides is always empty and migration_page never runs. Could we point it at the root file, like Flutter does?
Suggested change
| if guides := sorted((ROOT / "docs").glob("migration-*.md"), reverse=True): | |
| if guides := [g for g in [ROOT / "MIGRATION.md"] if g.exists()]: |
Closed
3 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gewenyu99
marked this pull request as draft
November 12, 2026 17:36
3 of 13 tasks
Contributor
Author
|
Combined into #973. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The migration page on posthog.com shows two titles: the front matter title "PostHog Android SDK migration guides", then the guide's own H1. With one guide, the generator now uses the guide's H1 as the page title and drops the H1 from the body. With more than one guide, nothing changes.
The guide rewrites that use this are in separate PRs. The Python SDK has the same change in PostHog/posthog-python#1244.
💚 How did you test it?
Ran migration_page on a one-guide and a two-guide input. The script has no test suite.
📝 Checklist
🤖 Agent context
Human-driven (agent-assisted)
🤖 Generated with Claude Code