-
Notifications
You must be signed in to change notification settings - Fork 64
feat(pi): inject first-party local MCP tools #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jonathanlab
wants to merge
3
commits into
main
Choose a base branch
from
fix/pi-local-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
apps/code/src/main/platform-adapters/desktop-pi-runtime-factory.test.ts
This file was deleted.
Oops, something went wrong.
24 changes: 0 additions & 24 deletions
24
apps/code/src/main/platform-adapters/desktop-pi-runtime-factory.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
packages/agent/src/adapters/local-tools/mcp-server.integration.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { mkdtemp, rm } from "node:fs/promises"; | ||
| import { tmpdir } from "node:os"; | ||
| import { join } from "node:path"; | ||
| import { Client } from "@modelcontextprotocol/sdk/client/index.js"; | ||
| import { StdioClientTransport } from "@modelcontextprotocol/sdk/client/stdio.js"; | ||
| import { afterEach, describe, expect, it } from "vitest"; | ||
|
|
||
| const directories: string[] = []; | ||
|
|
||
| async function temporaryDirectory(): Promise<string> { | ||
| const directory = await mkdtemp(join(tmpdir(), "local-tools-mcp-server-")); | ||
| directories.push(directory); | ||
| return directory; | ||
| } | ||
|
|
||
| afterEach(async () => { | ||
| await Promise.all( | ||
| directories | ||
| .splice(0) | ||
| .map((directory) => rm(directory, { force: true, recursive: true })), | ||
| ); | ||
| }); | ||
|
|
||
| describe("local-tools MCP server", () => { | ||
| it("starts the bundled server and executes an enabled tool", async () => { | ||
| const cwd = await temporaryDirectory(); | ||
| const client = new Client({ name: "local-tools-test", version: "1.0.0" }); | ||
| const transport = new StdioClientTransport({ | ||
| command: process.execPath, | ||
| args: [ | ||
| join(process.cwd(), "../../node_modules/tsx/dist/cli.mjs"), | ||
| join(process.cwd(), "src/adapters/local-tools/mcp-server.ts"), | ||
| ], | ||
| cwd, | ||
| env: { | ||
| PATH: process.env.PATH ?? "", | ||
| POSTHOG_LOCAL_TOOLS_CTX: Buffer.from( | ||
| JSON.stringify({ cwd, taskId: "task-1", taskRunId: "run-1" }), | ||
| ).toString("base64"), | ||
| POSTHOG_LOCAL_TOOLS_ENABLED: "speak", | ||
| }, | ||
| }); | ||
|
|
||
| try { | ||
| await client.connect(transport); | ||
| const tools = await client.listTools(); | ||
| const result = await client.callTool({ | ||
| name: "speak", | ||
| arguments: { text: "Completed the task", kind: "done" }, | ||
| }); | ||
|
|
||
| expect(tools.tools.map((tool) => tool.name)).toEqual(["speak"]); | ||
| expect(result.content).toEqual([{ type: "text", text: "ok" }]); | ||
| } finally { | ||
| await client.close(); | ||
| } | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a packaged desktop Pi session enables a first-party local tool, the app launches
.vite/build/mcp-server.jsas a standalone Node script, but this new asset is not included inasarUnpackalongsiderpc-host.js, causing the MCP child and its tools to fail at startup.Knowledge Base Used: PostHog Code Desktop App (
apps/code)Prompt To Fix With AI