Skip to content

Remove skill buttons from the task header #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cvolzer3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove skill buttons from the task header #3971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions apps/code/snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,34 +672,6 @@ snapshots:
hash: v1.k4693efd2.e01a8a548c694761b9f2a575268f420f653ad7eb9d26c2e33dc245ab03415fcf.Z5Ut_gF62xXnxkDgBXxE3yk6UDIAEVX5Sw_rKBPsqps
settings-personalizationsettings--synced-truncated--light:
hash: v1.k4693efd2.3c9f0dfa759b8c174abd8754593f0db9fd1518ff5225cccdcf0c3e83d4cdbe77.BqdmyuIiYJuGmHCQiRVAaBMk-xgycYOgVfwuMqma4LY
skill-buttons-skillbuttonactionmessage--add-analytics--dark:
hash: v1.k4693efd2.6d4ce4fac8e23a50efbbfaf24c2e11f8981f6778af2bfb2ca559749d7bda0eca.OnypKY5jyJSbQUZtTVcUy-eXC2euU-xQ2wFBYJOsKwI
skill-buttons-skillbuttonactionmessage--add-analytics--light:
hash: v1.k4693efd2.f9611d356ec29fdbeaa559fd1fad74ef5240edf099ca6b0c98bb000c8ecebb99.kLrb06q55BNiaXt5IiOa5GMJnSBLEE2XpPlzFclgkyc
skill-buttons-skillbuttonactionmessage--add-error-tracking--dark:
hash: v1.k4693efd2.4d3fb8903585f88035fe7f11bd131fb5469b1bcfa56e850fc872a90965b9a9a8.8wlRUb95tyzSof7imJ7zs_y03dvbRmH4WFjX541w5HE
skill-buttons-skillbuttonactionmessage--add-error-tracking--light:
hash: v1.k4693efd2.cfebda50da261d92f05d65771b89733969966491eae709a7ad0985af7d92b2af.cJib8NTQeUDwiCFGyKZZrzOkYB6wZpzj2lQTKoCoX2M
skill-buttons-skillbuttonactionmessage--add-logging--dark:
hash: v1.k4693efd2.0683c4cb4d3758ccfb3070a73e3f388624949cf359ff5e236e7f644bf8149ebd.nbHO3MGaY0eezUGvbSffJ2mWnwYGcv_Ls5Ftd7TamFc
skill-buttons-skillbuttonactionmessage--add-logging--light:
hash: v1.k4693efd2.089572e8d90c2ce17d03eb0d1f4028f28b0b106c262ffb5aa176efc67aac6961.aE-7mciin1bJeXhS3NO9MIdbA7p1V2yv7I9_av5qiuk
skill-buttons-skillbuttonactionmessage--create-feature-flag--dark:
hash: v1.k4693efd2.9e76cce0670827af38126d82091a1ddbff6fa46851eb5282307562828f33fffe.dLGLJgQ0h7Qbea4TkB_10bM1S7YhP7MtLWly5a8w8pI
skill-buttons-skillbuttonactionmessage--create-feature-flag--light:
hash: v1.k4693efd2.1816aed1a5153e40d66db8ded2823492fb2c6a2119e9dafc2e3e28b78efc0cd3.pWhUy7sCTfgQ-9SOY7Otzb21YPkdPalRmF1LpFaCE7o
skill-buttons-skillbuttonactionmessage--instrument-llm-calls--dark:
hash: v1.k4693efd2.45cd285f3dde88ec3a42d6124267f8b4927d6241ec5e6a32531d6c4d25f62fe4.6KVWQAustG4YSrWUwC8fT6PTTf8s6cRLqOicWuSD61g
skill-buttons-skillbuttonactionmessage--instrument-llm-calls--light:
hash: v1.k4693efd2.7c401e13f085e5fda6fe8b175bea7aba836e35d72ace33fa425893ad703ba874.uKLTlUu1eQrQQ_AroVKlbzvm7W10tJ1O_RqyxSg1aTQ
skill-buttons-skillbuttonactionmessage--run-experiment--dark:
hash: v1.k4693efd2.e747a3b5d0983a7a125335f1d95cc7735dafda73abdb3f63ccfadde0482c5ce9.tjc4lMKeaOJjLLxd9tivmgKLshzHZwuSAa_MbqwN_20
skill-buttons-skillbuttonactionmessage--run-experiment--light:
hash: v1.k4693efd2.c18264887c67224ea1196646ff27f31ef9d79add87b5e9dfead377fcaf0dc941.MwzR7Yyd4le31Qm7RB2yk-qLk5ujgLkN-cMAB2WQ9_k
skill-buttons-skillbuttonsmenu--default--dark:
hash: v1.k4693efd2.cfff4c6bbb0acef1c9941b21d2f69c24b234c2c206282acf6fcada0cb2bd2386.xILjVPp8ecQmGbPjGDdhbRyi9KFPpA_1nfYF3bfjwuc
skill-buttons-skillbuttonsmenu--default--light:
hash: v1.k4693efd2.eb9bd49b9700641f6f3c90653447c9767c52e997afec9843e8649b90752faad3.VdxEtBwtkU3ioy2evcNbrEKxPjQ1GDUpZAQzFe-Uho4
spaces-taskfeedrow--agent-origin--dark:
hash: v1.k4693efd2.82f8c70a399c9ea768201933e202fcc2fde74332c5153aeabf6835ace79beee6.yEZq_qnKxItv5u0Ydcqa1B4VCwv8lwXUvcaFScE2XO0
spaces-taskfeedrow--agent-origin--light:
Expand Down
29 changes: 8 additions & 21 deletions packages/core/src/sessions/sessionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ export interface ISessionStore {
}

export interface SessionServiceHelpers {
extractSkillButtonId: (...args: any[]) => any;
combineQueuedCloudPrompts: (...args: any[]) => any;
getCloudPromptTransport: (...args: any[]) => any;
resolveLocalSkillCommandPrompt?: (prompt: string) => Promise<string | null>;
Expand Down Expand Up @@ -3555,7 +3554,7 @@ export class SessionService {
});

// Show the user's message in the chat immediately, before any respawn
this.applyOptimisticPrompt(session.taskRunId, blocks, promptText);
this.applyOptimisticPrompt(session.taskRunId, promptText);

if (promptReferencesAbsoluteFolder(prompt)) {
const repoPath = this.localRepoPaths.get(taskId);
Expand Down Expand Up @@ -3681,30 +3680,18 @@ export class SessionService {
}
}

private applyOptimisticPrompt(
taskRunId: string,
blocks: ContentBlock[],
promptText: string,
): void {
private applyOptimisticPrompt(taskRunId: string, promptText: string): void {
this.d.store.updateSession(taskRunId, {
isPromptPending: true,
promptStartedAt: Date.now(),
pausedDurationMs: 0,
});

const skillButtonId = this.d.h.extractSkillButtonId(blocks);
if (skillButtonId) {
this.d.store.appendOptimisticItem(taskRunId, {
type: "skill_button_action",
buttonId: skillButtonId,
});
} else {
this.d.store.appendOptimisticItem(taskRunId, {
type: "user_message",
content: promptText,
timestamp: Date.now(),
});
}
this.d.store.appendOptimisticItem(taskRunId, {
type: "user_message",
content: promptText,
timestamp: Date.now(),
});
}

private async sendLocalPrompt(
Expand All @@ -3714,7 +3701,7 @@ export class SessionService {
options: { optimisticApplied?: boolean; isRecoveryResend?: boolean } = {},
): Promise<{ stopReason: string }> {
if (!options.optimisticApplied) {
this.applyOptimisticPrompt(session.taskRunId, blocks, promptText);
this.applyOptimisticPrompt(session.taskRunId, promptText);
}

try {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/sessions/sessionServicePromptRecovery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function createHarness() {
const usageLimitShow = vi.fn();
const deps = {
store,
h: { extractSkillButtonId: () => undefined },
h: {},
log: { info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() },
toast: { error: vi.fn(), info: vi.fn() },
track: vi.fn(),
Expand Down
6 changes: 4 additions & 2 deletions packages/core/src/setup/buildDiscoveredTaskPrompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import type { DiscoveredTask } from "@posthog/core/setup/types";
import { SKILL_BUTTON_CATALOG } from "@posthog/core/skill-buttons/catalog";

const EXPERIMENT_TASK_PROMPT =
"Set up a PostHog experiment for the feature in this task. Use the PostHog MCP to create the feature flag with control and test variants, then create the experiment in draft with a clear hypothesis and primary metric tied to the feature's success. Wire the variant into the code via posthog.getFeatureFlag. Only launch the experiment if the feature is already live in production — otherwise leave it in draft and tell me to launch it after this is merged and deployed.";

function buildExperimentTaskPrompt(task: DiscoveredTask): string {
const sections: string[] = [
SKILL_BUTTON_CATALOG["run-experiment"].prompt,
EXPERIMENT_TASK_PROMPT,
"",
"Use the analysis below as the starting point.",
"",
Expand Down
104 changes: 0 additions & 104 deletions packages/core/src/skill-buttons/catalog.ts
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions packages/core/src/skill-buttons/prompts.test.ts
View file
Open in desktop

This file was deleted.

42 changes: 0 additions & 42 deletions packages/core/src/skill-buttons/prompts.ts
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions packages/shared/src/analytics-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@ export type FeedbackType = "good" | "bad" | "general";
type FileOpenSource = "sidebar" | "agent-suggestion" | "search" | "diff";
export type FileChangeType = "added" | "modified" | "deleted";
type StopReason = "user_cancelled" | "completed" | "error" | "timeout";
export type SkillButtonId =
| "add-analytics"
| "create-feature-flags"
| "run-experiment"
| "add-error-tracking"
| "instrument-llm-calls"
| "add-logging";
type SkillButtonSource = "primary" | "dropdown";
export type CommandMenuAction =
| "home"
| "new-task"
Expand Down Expand Up @@ -288,12 +280,6 @@ export interface BrainrotActivatedProperties {
filled_cells: number;
}

export interface SkillButtonTriggeredProperties {
task_id: string;
button_id: SkillButtonId;
source: SkillButtonSource;
}

// Settings events
export interface SettingChangedProperties {
setting_name: string;
Expand Down Expand Up @@ -1272,7 +1258,6 @@ export const ANALYTICS_EVENTS = {
COMMAND_MENU_ACTION: "Command menu action",
COMMAND_CENTER_VIEWED: "Command center viewed",
BRAINROT_ACTIVATED: "Brainrot activated",
SKILL_BUTTON_TRIGGERED: "Skill button triggered",
POSTHOG_WEB_OPENED: "PostHog web opened",
SIDEBAR_NAV_ITEM_CLICKED: "Sidebar nav item clicked",
SIDEBAR_CUSTOMIZED: "Sidebar customized",
Expand Down Expand Up @@ -1449,7 +1434,6 @@ export type EventPropertyMap = {
[ANALYTICS_EVENTS.COMMAND_MENU_ACTION]: CommandMenuActionProperties;
[ANALYTICS_EVENTS.COMMAND_CENTER_VIEWED]: never;
[ANALYTICS_EVENTS.BRAINROT_ACTIVATED]: BrainrotActivatedProperties;
[ANALYTICS_EVENTS.SKILL_BUTTON_TRIGGERED]: SkillButtonTriggeredProperties;
[ANALYTICS_EVENTS.POSTHOG_WEB_OPENED]: never;
[ANALYTICS_EVENTS.SIDEBAR_NAV_ITEM_CLICKED]: SidebarNavItemClickedProperties;
[ANALYTICS_EVENTS.SIDEBAR_CUSTOMIZED]: SidebarCustomizedProperties;
Expand Down
Loading
Loading