Fix py2-style except clauses that made modules unimportable - #1
Open
poolside-eric wants to merge 2 commits into
Open
Fix py2-style except clauses that made modules unimportable#1poolside-eric wants to merge 2 commits into
poolside-eric wants to merge 2 commits into
Conversation
`except A, B:` is Python 2 syntax and raises SyntaxError at import time under Python 3, so climate.py, config_flow.py and sensor.py could not be loaded at all — the integration shipped unloadable in 0.1.0. Parenthesize the exception tuples in all four sites, and gate CI on `compileall` first: hassfest and the HACS action validate metadata, not code, so a module with a syntax error passes both and the failure only surfaces when Home Assistant tries to import it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
setup-python@v5 targets Node 20, which GitHub now force-runs on Node 24 and annotates as deprecated. v7 declares node24 natively; the only input removed since v5 is `pip-install`, which the compile job does not use. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
except A, B:is Python 2 syntax and raises SyntaxError at import timeunder Python 3, so climate.py, config_flow.py and sensor.py could not be
loaded at all — the integration shipped unloadable in 0.1.0.
Parenthesize the exception tuples in all four sites, and gate CI on
compileallfirst: hassfest and the HACS action validate metadata, notcode, so a module with a syntax error passes both and the failure only
surfaces when Home Assistant tries to import it.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com