Model NY IT-214 2025+ flat credit-amount tables; fix elderly-dependent tier and gate rate

changelog.d/ny-it214-2025-amount-tables.fixed.md

@@ -0,0 +1,5 @@
+Corrected the New York IT-214 real property tax credit:
+- uses the 2025+ flat credit-amount tables (Part RR of Chapter 59 of the Laws of 2025) instead of the pre-2025 50%-of-excess formula
+- grants the elderly amount when a claimed dependent is 65 or older
+- keeps income exactly at a band top in that band (Table 1 rate, Tables A and B, and the pre-2025 credit-limit chart previously shifted it to the next band)
+- rounds income to whole dollars, half up, before the income-band lookups and the $18,000 limit, per the IT-214 instructions

policyengine_us/parameters/gov/states/ny/tax/income/credits/real_property_tax/amount/elderly.yaml

@@ -0,0 +1,40 @@
+description: New York provides this real property tax credit amount for filers with one elderly taxpayer.
+
+brackets:
+  - threshold:
+      2025-01-01: -.inf
+    amount:
+      2025-01-01: 375
+  - threshold:
+      2025-01-01: 3_000
+    amount:
+      2025-01-01: 330
+  - threshold:
+      2025-01-01: 5_000
+    amount:
+      2025-01-01: 300
+  - threshold:
+      2025-01-01: 7_000
+    amount:
+      2025-01-01: 260
+  - threshold:
+      2025-01-01: 9_000
+    amount:
+      2025-01-01: 230
+  - threshold:
+      2025-01-01: 11_000
+    amount:
+      2025-01-01: 200
+  - threshold:
+      2025-01-01: 14_000
+    amount:
+      2025-01-01: 150
+metadata:
+  type: single_amount
+  threshold_unit: currency-USD
+  threshold_period: year
+  amount_unit: currency-USD
+  label: New York real property tax credit elderly amount
+  reference:
+    - title: 2025 Form IT-214 Table A
+      href: https://www.tax.ny.gov/pdf/current_forms/it/it214_fill_in.pdf#page=3

policyengine_us/parameters/gov/states/ny/tax/income/credits/real_property_tax/amount/non_elderly.yaml

@@ -0,0 +1,28 @@
+description: New York provides this real property tax credit amount for filers with no elderly taxpayer.
+
+brackets:
+  - threshold:
+      2025-01-01: -.inf
+    amount:
+      2025-01-01: 75
+  - threshold:
+      2025-01-01: 5_000
+    amount:
+      2025-01-01: 70
+  - threshold:
+      2025-01-01: 9_000
+    amount:
+      2025-01-01: 60
+  - threshold:
+      2025-01-01: 14_000
+    amount:
+      2025-01-01: 50
+metadata:
+  type: single_amount
+  threshold_unit: currency-USD
+  threshold_period: year
+  amount_unit: currency-USD
+  label: New York real property tax credit non-elderly amount
+  reference:
+    - title: 2025 Form IT-214 Table B
+      href: https://www.tax.ny.gov/pdf/current_forms/it/it214_fill_in.pdf#page=3

policyengine_us/parameters/gov/states/ny/tax/income/credits/real_property_tax/excess_real_property_tax.yaml

@@ -2,7 +2,7 @@ description: New York deems real property taxes (or rent equivalent) over this p
 
 brackets:
   - threshold:
-      2000-01-01: 0
+      2000-01-01: -.inf
     amount:
       2000-01-01: 0.035
   - threshold:

policyengine_us/parameters/gov/states/ny/tax/income/credits/real_property_tax/maximum/elderly.yaml

@@ -2,7 +2,7 @@ description: New York sets this maximum real property tax credit for filers with
 
 brackets:
   - threshold:
-      2000-01-01: 0
+      2000-01-01: -.inf
     amount:
       2000-01-01: 375
   - threshold:

policyengine_us/parameters/gov/states/ny/tax/income/credits/real_property_tax/maximum/non_elderly.yaml

@@ -2,7 +2,7 @@ description: New York sets this maximum real property tax credit for filers with
 
 brackets:
   - threshold:
-      2000-01-01: 0
+      2000-01-01: -.inf
     amount:
       2000-01-01: 75
   - threshold:
@@ -42,7 +42,7 @@ brackets:
     amount:
       2000-01-01: 57
   - threshold:
-      2000-01-01: 1_0000
+      2000-01-01: 10_000
     amount:
       2000-01-01: 55
   - threshold:

policyengine_us/parameters/gov/states/ny/tax/income/credits/real_property_tax/uses_flat_amount_table.yaml

@@ -0,0 +1,13 @@
+description: New York provides the real property tax credit as a flat amount looked up by federal adjusted gross income when this is true, under the New York State personal income tax.
+values:
+  2000-01-01: false
+  2025-01-01: true
+metadata:
+  unit: bool
+  period: year
+  label: New York real property tax credit uses flat amount table
+  reference:
+    - title: Tax Law Section 606(e)
+      href: https://www.nysenate.gov/legislation/laws/TAX/606
+    - title: 2025 Form IT-214 Tables A and B
+      href: https://www.tax.ny.gov/pdf/current_forms/it/it214_fill_in.pdf#page=3