Fix MT staxbc/v40 display, add MN homestead refund to v37, refresh taxsimtest binaries - #1150
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 23, 2026
PavelMakarchuk
force-pushed
the
fix/mt-staxbc-v40-display
branch
from
August 23, 2026 22:17
a9c1e48 to
a160024
Compare
…xsimtest binaries (#1122, #968) - MT staxbc: new adapter recombines the before-non-refundable-credit indiv/joint variables per PE's filing-mode choice; the previous mapping (mt_income_tax_before_refundable_credits_unit) is after non-refundable credits and printed 0.00, which misled taxsim #1122. - v40: recompute credit totals on the rebate-free twin so one-time rebates appear at their netted (capped) value in srebate only, not at their uncapped list value in Total Credits (2,291.45 -> 1,041.45 on the #1122 record, matching TAXSIM). - v37: add MN mn_homestead_credit_refund so the Form M1PR refund is visible in the property-tax-credit channel (taxsim #968). - Refresh resources/taxsimtest binaries: osx/linux from out2psl (cd2026081819; the stata-page osx is a stale 2025 build), windows from the canonical taxsimtest.exe URL (cd2026081318, PE32+ — out2psl/windows serves a stale 32-bit June build). Drop stale -new/-bak osx copies; README updated with the source guidance. VA 2021 opt(30) probe passes on osx (siitax 2068.05, srebate 500); CI's test_taxsim_opt30 verifies linux/windows. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PavelMakarchuk
force-pushed
the
fix/mt-staxbc-v40-display
branch
from
August 23, 2026 22:32
a160024 to
5e6566f
Compare
…f now formats markdown) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two display artifacts that produced taxsim #1122, implements the emulator side of #968, and refreshes the bundled
taxsimtestbinaries.MT
staxbc(#1122)MT mapped
staxbctomt_income_tax_before_refundable_credits_unit, which is after non-refundable credits — the 2021 income tax rebate netted it to 0.00, which is what suggested "PE allows the full $1,250" in #1122. PE-US has no unit-level before-non-refundable variable, so a new component adapter (adapter:mt_income_tax_before_non_refundable_credits) recombines the_indiv/_jointbefore-credit variables using the filing mode PE actually chose (argmin of the after-credit amounts when MFS-on-same-return is allowed).v40Total Credits (general, not MT-specific)v40summed the raw state credit lists, so one-time rebates appeared at their uncapped list values ($1,250 for MT) whilesrebatecarried the capped netted amount. TAXSIM keeps one-time rebates out of v40 entirely.v40is now recomputed on the existing rebate-free twin simulation whenever it exists, so rebates appear only insrebateat their netted value. This also future-proofs CT 2021 once PolicyEngine/policyengine-us#9274 (2021 CT child tax rebate re-booking) lands.MN
v37(#968)Adds
MN: mn_homestead_credit_refundto thev37map so the Form M1PR Homestead Credit Refund is visible in the property-tax-credit channel (previously it appeared nowhere in emulator output).Binary refresh
resources/taxsimtestbinaries (osx/linux/windows) updated from NBER build 2026-05-21 to 2026-08-18; stale-new/-bakosx copies removed. The new build includes the MN renter's-credit fix and now reports MTstaxbc17.30 on the #1122 record.Validation (taxsim #1122 record, idtl 5)
staxbcsrebatev40v37Tests: 89 passing across the affected + binary-dependent files (
test_state_output_adapters,test_net_of_rebates,test_mappers,test_e2e,test_cli_idtl5,test_stitched_runner,test_taxsim_options). Theoutput/sample CSVs were regenerated (they predated thesrebatecolumn).Closes #1122-adjacent display issues; emulator side of #968.
🤖 Generated with Claude Code