Spin while the parameter index loads - #1176
Open
PavelMakarchuk wants to merge 1 commit into
Open
Conversation
The build page announced "Loading the parameter index…" in static grey text for the seconds it takes to fetch and index the US tree, which reads more like a dead page than work in progress. Both waits on the page — the search index and the policy tree — now carry a spinner beside the same wording. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build page announced "Loading the parameter index…" in static grey text for the seconds it takes to fetch and index the US tree (87,991 entries). Static text through a multi-second wait reads like a dead page.
Both waits on the page now carry a spinner beside the same wording: the search index, and the policy tree behind the toggle. The tree is included because it is the same metadata fetch — one spinning and one static would have looked like a bug.
Testing
The live page loads from a warm cache too fast to screenshot the state reliably, so the proof is a test:
BuildPagerendered against an empty store — the cold-load condition — asserts the spinner is present and the search box is not. 7 pass inBuild.test.tsx; typecheck and eslint clean.🤖 Generated with Claude Code