Repository navigation
fix: make Route 42 Golbat night-only in Crystal - #1720
Merged
Merged
Conversation
jemarq04
approved these changes
Nov 11, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
The goal of this PR is to add
time-nightto encounter56524, making it match the other two Golbat slots on this route. Golbat then has a 15% encounter chance at night, and does not appear during the morning or day.Closes #1139.
References
https://github.com/pret/pokecrystal/blob/3c813b0b4d82b39bf62185aceffb76fd6026c70b/data/wild/johto_grass.asm#L1545-L1571
56524identifies the level 16 Golbat using slot544:https://github.com/PokeAPI/pokeapi/blob/5cbeb3f3eb55a9b86da52c4869336f9d61fdd6d7/data/v2/csv/encounters.csv#L52710
544has a 1% encounter chance:pokeapi/data/v2/csv/encounter_slots.csv
Line 545 in 5cbeb3f
56524:https://github.com/PokeAPI/pokeapi/blob/5cbeb3f3eb55a9b86da52c4869336f9d61fdd6d7/data/v2/csv/encounter_condition_value_map.csv#L16203-L16207
Testing
Built the local database before and after the change and checked both Golbat's encounter endpoint and the Route 42 location-area endpoint.
During testing, I confirmed that all three Golbat slots now require
time-night, with chances totaling 15%. Route 42's grass encounter chances now total 100% in the morning, day, and night. The API responses are otherwise the same.All 69 tests passed, along with pre-commit, lint, formatting, and type checks.
AI coding assistance disclosure
I used AI assistance from Codex (GPT-6.1 Sol, high reasoning effort) to investigate the issue, compare PokeAPI's CSV records with Crystal's disassembled encounter table, and apply the fix. The decisions and PR text are my own.
Contributor check list