[FallenDeity]

Change description

• Add nihil light
• add pla mastery support
• add new moves along with localized flavor text names and desc from in game (including missing za moves, reminder moves, egg etc)
• add missing machines for legends za from its dlc to main so the learnsets which are based on base game can use it (same for bdsp)
• add localized texts for abilities
• added missing version group and region linking

Closes #1717 #1316 #1534 #1370 #943

Partial
#1153 - this adds a reminder method distinction but this also ask for evolution move learn method trigger which is redundant imo since we already use a level 0 sentinel if users want they also derive the actual from the evolution endpoint and level learned at explicitly

Confusion with egg moves some of the issues that are open are regarding people being confused why the egg moves are not on evolved forms too we can close these issues but imo we should add some documentation in the site about it

#1503 #897 #828

cc: @jemarq04 @notblisy

AI coding assistance disclosure

Used it to orchestrate the mapping from original dumps to pokeapi and audit

Contributor check list

• I have written a description of the contribution and explained its motivation.
• I have written tests for my code changes (if applicable).
• I have read and understood the AI Assisted Contribution guidelines.
• I will own this change in production, and I am prepared to fix any bugs caused by my code change.

[FallenDeity]

edit: reused the mastery col we had before for both za and pla enhancement move levels like plus moves and agile/strong we were not using this field before in build.py so it was never exposed renaming it shouldnt break anything

edit 2: i have a structure in mind for variant move stats which i have but this pr alone might be a bit big lmk if that is fine as part of this pr or i should make a separate pr

[jemarq04]

I can't comment on individual lines since there are so many changes, so I'll just put them in this thread.

Is there a reason you changed some of the order fields in this file? How did you determine they were wrong?

[jemarq04]

I see you removed TM moves for certain pokemon with alternate regional forms (Typhlosion, Samurott, ...). I'm assuming this has to do with your work on that in your comment?

[jemarq04]

Why did larvesta lose its bug-bite move from TM?
Similarly, indeedee-female lost some moves from TM?

[jemarq04]

I see some pokemon lost their level 0 level-up moves - likely replaced with the new reminder method. Same comment as before - we can leave this as-is since it can be treated as a "missed" level-up move that a player would need the reminder for.

[jemarq04]

Of course, I couldn't review every line (especially the large number added at the end) so I'll trust you on those and we can just catch things as we find them in the future.

[FallenDeity]

reply to comments in order

• "Order" field not populated for Pokémon whose level-up moves are not in numerical order #1534 and Missing 'order' entry for Gen 9 Pokémon moves #943 now order here for all cases were determined from rom data dumps in case of earlier generations i used the linked pret disassembly for newer switch games i used my local dumps here is an example of dragonite from bdsp/swsh dumps

matches the order present online in stuff like bulbapedia too https://bulbapedia.bulbagarden.net/wiki/Dragonite_(Pok%C3%A9mon)/Generation_VIII_learnset

• yep this is related to Hisui Starter Trio Move compatibilities used in base forms #1370 where regional form exclusive tms/moves leaked into the base forms so clean up related to that

• larvesta bug bite wasnt removed swsh still has it

made a little visualizer to make it easier to review for me, what was removed was a wrong entry carried over from swsh to sv where it still learnt bug bite via level up which is wrong because in sv it learns it only via tm

for example currently live which is wrong

for indeedee there was a move leak between male and female which have diff moves which i fixed for example female cannot learn expanding force in sv it gets alluring voice instead

this fixes the discrepancy

• they werent lost or removed for example leer as of now is level 0 on walking wake they were just moved to level 1 with level up as trigger they werent made reminder reason is level 0 is a sentinel we currently use for marking a move that a pokemon learn on evolution these myths/mons dont evolve so level 0 seemed wrong check Lack of distinction In Evolution and Reminder moves #1153 and rom had them as level 1 too so i used that

for other cases where a move is learnt on evo for ex annihlape shadow punch i left the level learned at to 0 same as our standard practice

also yeah ill resort the file so the additons stay near its relative position rather than eof should make it easier to review

[jemarq04]

Great, thanks for the explanations! In that case, everything is looking good to me.

[FallenDeity]

awesome let's see if we can get a review from blisy or naramsim once #1719 is merged we can merge this one in