Rename Dep marker to Dependency and align published wiki with copier template#244
Merged
Conversation
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 164 164
Lines 18610 18612 +2
Branches 1234 1235 +1
=======================================
+ Hits 17312 17314 +2
Misses 1068 1068
Partials 230 230 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
…plicates Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
ee901bb to
31763ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #239 (now merged). Two independent changes:
1. Rename the
Depmarker toDependencyThe explicit container-dependency marker added in #239 was named
Dep. Every other public dependency-related type in the library spells the word out (DependencySpec,EvaluationDependency), as do the sibling markersFromContextandLazy. This renames the public markerDep→Dependencyfor consistency:Also silences a benign Pydantic serializer warning:
model_dump_json()on aDependency-marked model containing aCallableModelleaf previously emittedPydanticSerializationUnexpectedValue. The generated (schema-only,SkipValidation) field annotation for dependency-slot params now maps toAny, so no warning is emitted; ccflow still validates leaves against the real annotation.2. Fix the published wiki (align with copier template)
The GitHub wiki had duplicate/colliding
Contribute,Build-from-Source, andLocal-Development-Setuppages. The copier template (python-project-templates/base) stores these underdocs/wiki/contribute/, and the copier uplift (bd35d2e) added them there but left the old top-level copies behind. GitHub's wiki engine flattens page slugs, so the two sets collided.This removes the stale top-level duplicates and keeps the
contribute/versions, which are byte-identical to the template's rendered output. The flat sidebar links ([Build from Source](Build-from-Source)) continue to resolve to thecontribute/pages via gollum.