Conversation
This is the public SDK, so a reference that only resolves on a maintainer's machine reaches the widest audience of the three repositories. Genuine author/copyright attribution is left untouched. Broken on a clean clone: - README.md and .claude/commands/test-and-commit.md both instruct the reader to run ./run_clang_tidy.sh, which is not tracked. Every external contributor following the getting-started steps hits this. Replaced with the equivalent command. - CMakeLists.txt cited SUSTAINABILITY.md T0-3 for the wasm -Werror carve-out; no such file is tracked, so the comment now stands on its own. Environment-specific: - pj_plugins/tests/source_dialog_integration_test.cpp used 10.0.0.1, which can overlap a contributor's real LAN; 192.0.2.1 (TEST-NET-1) is the documentation-only equivalent. - pj_plugins/docs/dialog-plugin-guide.md offered a copyable example with initial_directory = "/data/bags", a mount an arbitrary machine lacks. - .github/workflows/release.yml wrote /tmp/remote_revs.json in five places instead of the runner-allocated temp dir, giving concurrent or local runs a fixed collision target. Now mktemp under $RUNNER_TEMP with a cleanup trap. Claude-Session: https://claude.ai/code/session_01JHCjCjntYefq2QyDagb8Dh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An audit of the tracked tree turned up references that either cannot resolve on a clean clone or assume one machine's environment. Companion PRs exist for
PJ4andpj-official-plugins.This is the public SDK, so a reference that only resolves on a maintainer's machine reaches the widest audience of the three repositories — an external contributor hits it on their first
git clone.Scope rule applied: fix only what breaks or exposes a machine. Genuine author/copyright attribution is deliberately untouched — the 329
Davide Faconticopyright sites,LICENSE,LICENSE-APACHEand the upstream dependency URLs are all unchanged.Broken on a clean clone
README.md:38and.claude/commands/test-and-commit.md:5./run_clang_tidy.sh, which is not tracked. It is step 3 of the documented getting-started flow, so every external contributor following the README hits it. Replaced with the equivalentgit ls-files … | xargs clang-tidycommand in both places, kept in sync.CMakeLists.txt:58SUSTAINABILITY.mdT0-3 for the wasm-Werrorcarve-out; no such file is tracked anywhere. The adjacent comment already explains the reason, so the dangling cross-reference is dropped and the comment stands on its own.Environment-specific
pj_plugins/tests/source_dialog_integration_test.cpp:200used10.0.0.1— RFC 1918 space that can overlap a contributor's real LAN. Now192.0.2.1(TEST-NET-1), the documentation-only equivalent, with identical test semantics.pj_plugins/docs/dialog-plugin-guide.md:776offered a copyable example withinitial_directory = "/data/bags", a root-level mount an arbitrary machine will not have. Now{}, letting the host pick..github/workflows/release.ymlwrote/tmp/remote_revs.jsonin five places rather than the runner-allocated temp dir, bypassing GitHub's temp-path abstraction and giving concurrent or local runs a fixed collision target. Now onemktempunder$RUNNER_TEMPwith a cleanup trap, quoted at all five uses.Verification
release.ymlre-parsed as YAML after the edit.clang-format --dry-run -Werrorclean on the changed test.Deliberately not fixed
pj_base/abi/baseline.abiembeds/home/runner/work/plotjuggler_core/...on lines 1 and 100 — CI checkout paths baked into a distributed artifact. Regenerating it properly means re-runningabidwwith--no-corpus-path --no-comp-dir-path --short-locs(or a-ffile-prefix-mapbuild) and diffing the result against the current ABI contract. That needs a build, so hand-editing the baseline would be worse than leaving it. Flagged for a follow-up.Also left alone under the scope rule, since neither breaks nor exposes a machine:
CHANGELOG.md:748,766names a person for thepj.data_processors.v1contract, andpj_plugins/CMakeLists.txt:677uses a "Keystone" codename that appears exactly once and is defined nowhere.https://claude.ai/code/session_01JHCjCjntYefq2QyDagb8Dh