Repository navigation
Strip the unit-test side of #ifndef __UNIT_TEST__ in strip.py - #134
Open
Stuartwastaken wants to merge 1 commit into
Open
Stuartwastaken wants to merge 1 commit into
Stuartwastaken wants to merge 1 commit into
Conversation
strip.py kept both sides of "#ifndef __UNIT_TEST__ ... #else", so the stripped homa_tx_pool.c defined homa_tx_pool_mem_nid twice and didn't compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strip.py kept both sides of
#ifndef __UNIT_TEST__ ... #else ... #endif: the #ifndef starts in the keep state and the #else set keep again instead of switching to strip. So the stripped homa_tx_pool.c defines homa_tx_pool_mem_nid twice (the real one and the unit-test stub) and doesn't compile.The #else now flips the state. Only homa_tx_pool.c's stripped output changes (the stub is gone); every other file that make net-next copies strips the same as before.
python3 util/strip.py homa_tx_pool.c | grep -c '^int homa_tx_pool_mem_nid'gives 2 before and 1 after.