Show loading overlay on inventory slots until their contents arrive - #3555
Open
yel0h wants to merge 2 commits into
Open
Show loading overlay on inventory slots until their contents arrive#3555yel0h wants to merge 2 commits into
yel0h wants to merge 2 commits into
Conversation
Wunka
suggested changes
Aug 26, 2026
Comment on lines
+90
to
+91
| if (count == 0) { | ||
| _ = loadingInventories.remove(clientId); |
Contributor
There was a problem hiding this comment.
this should never happen right?
(the remove not the == 0, so I would either do an assert that nothing was removed or just do an early return
Contributor
Author
There was a problem hiding this comment.
Well if the client receives that the inventory is empty, I immediately remove it from the inventories being loaded since there's nothing to wait for
Member
|
I think the best solution is to make chest opening server initiated. |
Contributor
Author
|
Ok, I added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server now also sends the number of items to expect, and the client counts them down as they arrive. Slots for an inventory that isn't loaded yet render with a dark overlay. All
.serverSharedinventories are tracked.Fixes #2700