#3228 grey out unusable items when using workbench - #3552
Conversation
Wunka
left a comment
Wunka
left a comment
There was a problem hiding this comment.
Welcome to Cubyz!
if you don't know: I am am not someone who can merge your code, so you will still receive a review by quantum.
| const Mode = enum { | ||
| normal, | ||
| takeOnly, | ||
| unfocused, | ||
| immutable, | ||
| }; |
There was a problem hiding this comment.
normal, takeOnly, and immutable actually represent logic behavior changes, whereas unfocused only affects rendering behavior. So I don't think unfocused fits here.
One example where this can shoot you in the foot is that the item slots in the creative window are takeOnly, and therefore aren't affected by your logic. Even though it would be nice if they were.
There was a problem hiding this comment.
That's a good point, it now applies the logic by inventory source instead of item slot mode. Though maybe the creative inventory should have it's own inventory source type instead of using .other?
|
This still requires more design discussions, see my comment on the issue: #3228 (comment) |
IntegratedQuantum
moved this from Easy to Review
to WIP/not ready for review
in PRs to review
3 participants
closes #3228