Move Phantasmal out of the Root - #3534
Open
TyrrelMeter wants to merge 26 commits into
Open
Conversation
Wunka
moved this from Waiting for artistic review
to WIP/not ready for review
in PRs to review
Contributor
|
Wow, only two days old and already merge conflicts... please fix |
Contributor
Author
|
@Wunka Not only was it a conflict in two days, it was a conflict that one of my other PRs made xD |
Contributor
Author
|
Alright merge conflicts solved |
Contributor
|
Now please fix formatting |
Wunka
moved this from WIP/not ready for review
to Waiting for artistic review
in PRs to review
IntegratedQuantum
moved this from Easy to Review
to Waiting for artistic review
in PRs to review
Member
|
since it makes changes to the biome (and moves one of them to a totally different area), this should go through artistic review first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Phantasmal Streamers and Starlight out of the root and into separate cave biomes spread throughout the cave layers. This PR fixes issue #2840. It also fixes lore issues.