Add SAM2 segmentation model bundle manifest - #3
Draft
griswaldbrooks wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Motivation
The ML 10.0 realignment replaces
moveit_pro_ml's per-file-path model loading with a versionedbundle manifest: one YAML file naming every graph a pipeline needs, with a SHA-256 digest per
artifact verified at load time.
moveit_pro_sam3already ships one (PickNikRobotics/moveit_pro_sam3#2);this adds the SAM2 point-prompted segmentation equivalent so
moveit_pro_ml::SAM2Segmentcan loadthis package.
Brief description
Adds
models/model.yamldeclaring the two graphsSAM2Segmentacquires —image_encoderanddecoder— under themoveit_pro.sam2_segment.v1graph ABI. Digests are the files' Git LFS OIDs,which are their SHA-256 content hashes.
No CMake change is needed:
models/is already installed wholesale.How it was tested
Manifest field names, schema version, and graph ABI checked against the loader
(
moveit_pro_ml::model::loadBundle) and theSAM2Segmentfacade's component-name and ABIvalidation. Full-stack validation runs in the paired
moveit_pro_example_ws PR,
which bumps this submodule.