Skip to content

Validate fixed-size parameter defaults during generation - #374

Open
Daniiiil1 wants to merge 1 commit into
PickNikRobotics:mainfrom
Daniiiil1:codex/validate-fixed-default-size
Open

Validate fixed-size parameter defaults during generation#374
Daniiiil1 wants to merge 1 commit into
PickNikRobotics:mainfrom
Daniiiil1:codex/validate-fixed-default-size

Conversation

@Daniiiil1

Copy link
Copy Markdown

Summary

  • reject fixed-capacity defaults that exceed the generated rsl::StaticVector or rsl::StaticString capacity
  • validate a configured fixed_size<> constraint against the default during code generation
  • preserve the current bounded-capacity semantics, so shorter defaults remain valid unless fixed_size<> requires an exact length
  • cover integer, double, and string arrays as well as fixed strings

This avoids generating code that can hit an rsl::StaticVector assertion before runtime validation runs. It also keeps the existing rsl containers and their ROS parameter assignment behavior.

Fixes #342

Testing

  • 27 Python generator tests passed
  • Black check with --skip-string-normalization passed
  • git diff --check passed

Signed-off-by: Daniil Mordanov <mordanovdania@gmail.com>
@Daniiiil1
Daniiiil1 marked this pull request as ready for review August 7, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fixed size arrays can be initialised with more values than capacity

1 participant