Skip to content

Validate bound validators against parameter types - #373

Open
Daniiiil1 wants to merge 1 commit into
PickNikRobotics:mainfrom
Daniiiil1:codex/validate-bound-types
Open

Validate bound validators against parameter types#373
Daniiiil1 wants to merge 1 commit into
PickNikRobotics:mainfrom
Daniiiil1:codex/validate-bound-types

Conversation

@Daniiiil1

Copy link
Copy Markdown

Closes #347

Summary

  • reject scalar bound validators on array parameters during generation
  • reject element-bound validators on scalar parameters
  • point each error to the compatible validator family
  • cover dynamic arrays, fixed arrays, and scalar parameters with regression tests

Validation

  • 8 targeted pytest cases passed
  • repository pre-commit hooks passed for check-ast, double-quote-string-fixer, Black, Codespell, and Pyupgrade
  • Python compileall passed
  • git diff --check passed

A full colcon build was not run because this machine does not have a ROS 2 environment.

Signed-off-by: Daniil Mordanov <mordanovdania@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Prone: bounds and element_bounds

1 participant