Skip to content

Fix router configuration to prevent 404 on deep link refresh #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhoenixMaster123 merged 2 commits into from
Aug 20, 2026
Merged

Fix router configuration to prevent 404 on deep link refresh #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ed014
fix: tell the router where the site starts, so a refreshed deep link …
PhoenixMaster123 Aug 20, 2026
7141158
ci: let the java job create check runs, so the test report actually p…
PhoenixMaster123 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ jobs:
java:
name: ${{ matrix.name }}
runs-on: ubuntu-latest
# The test report is published as a check run, which the read-only default token cannot create.
permissions:
contents: read
checks: write
strategy:
# One service failing should not hide the state of the other two.
fail-fast: false
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ import { RegisterPage } from './pages/RegisterPage'
export function App() {
return (
<AuthProvider>
<BrowserRouter>
{/*
The site is served from a subdirectory on GitHub Pages, so the router has to be told where
it starts. Without this every path arrives as /<repo>/books, matches no route, falls to the
catch-all and navigates to /books at the domain root - which really is a 404. BASE_URL is
'/' during development, so this is a no-op there.
*/}
<BrowserRouter basename={import.meta.env.BASE_URL}>
<Routes>
<Route path="/login" element={<LoginPage />} />
<Route path="/register" element={<RegisterPage />} />
Expand Down
Loading