Experiment with removing moving check from ReadyToNextMission - #2332
Open
Coronia wants to merge 1 commit into
Open
Experiment with removing moving check from ReadyToNextMission#2332Coronia wants to merge 1 commit into
Coronia wants to merge 1 commit into
Conversation
Coronia
added
Needs testing
⚙️T1
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of #2088. Before a techno is going to switch to another mission, it'll check if it's currently moving. While it's problematic for Jumpjet and Hover already, there's also the question that whether this is really needed
Make a PR for testing the behavior of its removal first, and then we can decide if we could just remove this check directly, or make it an option with an ini toggle, or not doing it at all. No issue has been found in my local test so far, but more test is needed under different scenarios