Allow other vehicles to attempt to move above the target like BalloonHover=yes - #1998
Closed
TaranDahl wants to merge 2 commits into
Closed
Allow other vehicles to attempt to move above the target like BalloonHover=yes#1998TaranDahl wants to merge 2 commits into
BalloonHover=yes#1998TaranDahl wants to merge 2 commits into
Conversation
TaranDahl
added
Needs testing
⚙️T1
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
# Conflicts: # CREDITS.md # docs/Fixed-or-Improved-Logics.md # docs/Whats-New.md # docs/locale/zh_CN/LC_MESSAGES/CREDITS.po # docs/locale/zh_CN/LC_MESSAGES/Fixed-or-Improved-Logics.po # src/Ext/WeaponType/Body.h
Coronia
requested changes
Jul 26, 2026
Coronia
left a comment
Coronia
left a comment
Contributor
There was a problem hiding this comment.
This add another SelectWeapon call which is debateable for performance. IDA suggests that there're already some existing calls of it, could we somehow reuse that instead of reimplementing it again?
Contributor
Author
|
Closing this because a similar function is implemented in #2088. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow other vehicles to attempt to move above the target like ZEP
BalloonHover=yesand a weapon with projectile withVertical=yeswill attempt to move above the target.BalloonHover=yesorVertical=yes.In
rulesmd.ini: