Skip to content

Always redact SIP authorization credentials - #19

Merged
PetrShtuka merged 1 commit into
mainfrom
codex/release-0.5.0-prep
Aug 14, 2026
Merged

Always redact SIP authorization credentials#19
PetrShtuka merged 1 commit into
mainfrom
codex/release-0.5.0-prep

Conversation

@PetrShtuka

Copy link
Copy Markdown
Owner

What changed

  • Always scrub Authorization and Proxy-Authorization values from PJSIP protocol traces, regardless of CallWaveLog.redactsIdentifiers.
  • Remove folded continuation lines belonging to authorization headers.
  • Replace the test that previously preserved raw credentials when identifier redaction was disabled.
  • Correct the field-testing guidance and document the security fix.
  • Point SwiftPM at the reproducible pjsip-2.17-ios15-opus-sha256.2 binary release.

Why

redactsIdentifiers = false is useful during device field testing, but it incorrectly disabled credential scrubbing too. Raw digest usernames, nonces and responses could therefore reach logs and custom logger callbacks. Identifier visibility and credential safety must be independent controls.

The previous PJSIP .1 tag also predated the SHA-256 patch and Opus license. The new immutable .2 tag points to commit 0522800, which contains the build script, patch, manifest and licenses used by the attached XCFramework.

Impact

Applications can continue exposing UUIDs, caller information and addresses during controlled diagnostics without exposing SIP credentials. The public API and binary checksum are unchanged.

Validation

  • Full package test suite passed on iPhone 17 Pro Simulator, including the new credential and folded-header regressions.
  • SwiftPM successfully downloaded the published .2 XCFramework and verified its checksum.
  • verify-pjsip-xcframework.sh confirmed iOS 15, device/simulator architectures, Apple TLS, IPv6, Opus and SHA-256.
  • git diff --check passed.

@PetrShtuka
PetrShtuka marked this pull request as ready for review August 14, 2026 06:01
@PetrShtuka
PetrShtuka merged commit ea76bc2 into main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant