Add call-quality warnings, no-media watchdog and QoS tagging - #15
Merged
Conversation
- CallWaveEventTypeCallQualityWarning with per-call latched reasons (packet loss, high jitter, high RTT, no media) carrying the statistics snapshot that crossed the engine-configured thresholds. - No-media watchdog: fires after noMediaTimeout connected seconds without inbound RTP and can optionally end the call (terminatesCallOnNoMedia). - Voice service-type tagging on SIP and RTP sockets, on by default via CallWaveEngineConfiguration.QoSTaggingEnabled. - CallWaveCallStatistics.estimatedMOS, a simplified E-model estimate. - Quality monitoring ticks once a second during active calls even when statisticsUpdateInterval is 0; periodic statistics events stay opt-in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что входит (кодовая часть P0 из плана улучшений)
P0.2 — события качества звонка
CallWaveEventTypeCallQualityWarningс причинамиCallWaveCallQualityWarning:PacketLoss,HighJitter,HighRoundTripTime,NoMedia.CallWaveEngineConfiguration:qualityWarningPacketLossThreshold(5 %),qualityWarningJitterThreshold(30 мс),qualityWarningRoundTripTimeThreshold(300 мс), выключательqualityWarningsEnabled.CallWaveCallStatistics, который его вызвал.CallWaveEvaluateCallQuality— правила покрыты тестами без живого SIP-звонка.P0.3 — no-media watchdog
noMediaTimeout(по умолчанию 5 с): если после CONNECT не пришло ни одного RTP-пакета — событиеNoMedia(«домофон ответил молчанием»).terminatesCallOnNoMedia(по умолчанию выключено).P0.5 — QoS/DSCP
PJ_QOS_TYPE_VOICEна SIP-транспортах (UDP/TCP/TLS) и на RTP-сокетах аккаунта. По умолчанию включено, выключательQoSTaggingEnabled.Дополнительно
CallWaveCallStatistics.estimatedMOS— упрощённая E-model (1.0–4.5, 0 = «нет данных») для событий статистики и экрана VoIP Logs.statisticsUpdateInterval = 0; периодические…CallStatisticsUpdatedостаются opt-in.Тесты
CallWaveCallQualityTests.m)../Scripts/run-package-tests.sh: 57/57 passed.Не входит (следующий PR, пересборка PJSIP)
PJ_SSL_SOCK_IMP_APPLEPJSIP собирается в режимеHAVE_NO_OPENSSL, где SHA-256-challenge не распознаётся — нужен патч к pjproject со встроенной реализацией SHA-256.