Stop logging configured Sure Petcare credentials#7
Draft
robinsondan87 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Hi. The whole approach of using this addon no longer applies as new firmware has been pushed to all the hubs preventing the previous DNS poison approach. I do however have a completely new approach. If you send me an email I can let you know how it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The add-on currently logs the configured cloud username and password during startup. These values can remain visible in Home Assistant Supervisor logs. The add-on only needs to know whether the values are present, not print the values themselves.
Validation
bash -n pethublocal/rootfs/etc/services.d/pethublocal/run