Skip to content

Stop logging configured Sure Petcare credentials#7

Draft
robinsondan87 wants to merge 1 commit into
PetHubLocal:mainfrom
robinsondan87:stop-logging-credentials
Draft

Stop logging configured Sure Petcare credentials#7
robinsondan87 wants to merge 1 commit into
PetHubLocal:mainfrom
robinsondan87:stop-logging-credentials

Conversation

@robinsondan87

Copy link
Copy Markdown

Summary

  • stop writing the configured Sure Petcare username and password to add-on logs
  • warn when either required credential is missing
  • keep the existing startup command and credential handling unchanged

Why

The add-on currently logs the configured cloud username and password during startup. These values can remain visible in Home Assistant Supervisor logs. The add-on only needs to know whether the values are present, not print the values themselves.

Validation

  • bash -n pethublocal/rootfs/etc/services.d/pethublocal/run
  • checked the run script no longer logs username/password values

@plambrechtsen

Copy link
Copy Markdown
Contributor

Hi. The whole approach of using this addon no longer applies as new firmware has been pushed to all the hubs preventing the previous DNS poison approach.

I do however have a completely new approach. If you send me an email I can let you know how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants