Skip to content

fix(inspector): complete Node 26 promise API parity - #7095

Merged
proggeramlug merged 1 commit into
fix/node-inspector-node-26-parityfrom
feat/node-inspector-promises-node-26-parity
Jul 31, 2026
Merged

fix(inspector): complete Node 26 promise API parity#7095
proggeramlug merged 1 commit into
fix/node-inspector-node-26-parityfrom
feat/node-inspector-promises-node-26-parity

Conversation

@TheHypnoo

Copy link
Copy Markdown
Member

Summary

Completes Node.js 26.5.0 parity for node:inspector/promises on top of the inspector core in #7090.

Changes

  • Implement Promise Session validation, lifecycle, post behavior, and disconnect rejection semantics.
  • Preserve native module exports, identities, descriptors, and the shared inspector backend required by the Promise wrapper.
  • Route constructor and promise-specific dispatch behavior through the existing inspector implementation.

Related issue

Closes #6773

Depends on #7090.

Test plan

  • ./run_parity_tests.sh --suite node-suite --module inspector-promises
    • 30 PASS, 0 FAIL, 0 COMPILE_FAIL, 0 crash, 0 NODE_FAIL, 0 SKIP
  • cargo build --release through the parity gate
  • cargo test --workspace not run (explicit task constraint)
  • No fixture, runner, skip, timeout, or .atl files changed

Screenshots / output

Not applicable.

Checklist

  • I have NOT bumped the workspace version or edited CLAUDE.md / CHANGELOG.md
  • My commits follow the fix: convention
  • I have read CONTRIBUTING.md and agree to the Code of Conduct

@TheHypnoo TheHypnoo added the type:bug Bug fix label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3992d22d-b6eb-4846-8774-dce2b2b184fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit d3e40f4 into fix/node-inspector-node-26-parity Jul 31, 2026
7 checks passed
@proggeramlug
proggeramlug deleted the feat/node-inspector-promises-node-26-parity branch July 31, 2026 01:10
proggeramlug added a commit that referenced this pull request Aug 1, 2026
* fix(inspector): complete Node 26.5 parity

* fix(inspector): complete promise API parity (#7095)

* fix(inspector): address review findings

* fix(inspector): address maintainer audit

---------

Co-authored-by: Ralph Küpper <ralph.kuepper@skelpo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants