Skip to content

chore: ignore buf lint naming error to avoid breaking changes - #3215

Open
junsazanami430u wants to merge 1 commit into
Permify:masterfrom
junsazanami430u:fix/buf-lint-named-error
Open

junsazanami430u wants to merge 1 commit into
Permify:masterfrom
junsazanami430u:fix/buf-lint-named-error

Conversation

@junsazanami430u

@junsazanami430u junsazanami430u commented Sep 28, 2026 •

Copy link
Copy Markdown

add linter ignore comment

Summary by CodeRabbit

  • Chores
    • Updated API definition annotations to align with naming conventions. These changes do not affect available operations or application behavior.

@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: eb5ef14d-1855-4092-ac16-de0b35a09bc4

📥 Commits

Reviewing files that changed from the base of the PR and between 7529af5 and f0fe700.

📒 Files selected for processing (1)
  • proto/base/v1/service.proto

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The service proto adds Buf lint-ignore comments for naming and request/response uniqueness rules before ten RPC declarations. No RPC signatures or behavior changed.

Changes

RPC lint suppressions

Layer / File(s) Summary
Add RPC lint-ignore comments
proto/base/v1/service.proto
Buf lint-ignore comments now precede the specified entity, relationship, bundle, and tenancy RPCs.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f0fe7

The RPC API is unchanged, and the lint suppressions work as intended. No actionable merge risk was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to f0fe7

The change affects 1 system.

Changed systems: proto

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — proto (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in proto/base/v1/service.proto: Added a Buf lint-ignore comment for the RPC request/response uniqueness rule before LookupEntity.
  • observed — Modified behavior in proto/base/v1/service.proto: Added Buf lint-ignore comments for request/response uniqueness and standard naming rules before LookupEntityStream.
  • observed — Modified behavior in proto/base/v1/service.proto: Added Buf lint-ignore comments for standard request and response naming rules before WriteRelationships.
  • observed — Modified behavior in proto/base/v1/service.proto: Added Buf lint-ignore comments for standard request and response naming rules before ReadRelationships.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'chore: ignore buf lint naming error to avoid breaking changes' directly describes the main change in the changeset. The summary confirms that the PR adds Buf lint-ignore commen…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 Buf (1.72.0)
proto/base/v1/service.proto

fatal: unable to access 'https://github.com/Permify/permify.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server
fatal: could not fetch f8f2aaf730a6df0518ffaa75417e40934ddcaf23 from promisor remote


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@junsazanami430u

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@junsazanami430u

Copy link
Copy Markdown
Author

recheck

@junsazanami430u

Copy link
Copy Markdown
Author

#3216

@junsazanami430u

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.29%. Comparing base (7529af5) to head (f0fe700).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3215      +/-   ##
==========================================
- Coverage   76.30%   76.29%   -0.01%     
==========================================
  Files          83       83              
  Lines        9215     9215              
==========================================
- Hits         7031     7030       -1     
- Misses       1634     1635       +1     
  Partials      550      550              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@omer-topal

Copy link
Copy Markdown
Contributor

Hello @junsazanami430u, thanks for the contribution. The commit author @sazajun1390 needs to sign the CLA before I can merge this. The CLA Assistant checks commit authors, not the PR author, so signing from this account doesn't register.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants