chore: ignore buf lint naming error to avoid breaking changes - #3215
junsazanami430u wants to merge 1 commit into
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe service proto adds Buf lint-ignore comments for naming and request/response uniqueness rules before ten RPC declarations. No RPC signatures or behavior changed. ChangesRPC lint suppressions
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The RPC API is unchanged, and the lint suppressions work as intended. No actionable merge risk was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Buf (1.72.0)proto/base/v1/service.protofatal: unable to access 'https://github.com/Permify/permify.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3215 +/- ##
==========================================
- Coverage 76.30% 76.29% -0.01%
==========================================
Files 83 83
Lines 9215 9215
==========================================
- Hits 7031 7030 -1
- Misses 1634 1635 +1
Partials 550 550 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hello @junsazanami430u, thanks for the contribution. The commit author @sazajun1390 needs to sign the CLA before I can merge this. The CLA Assistant checks commit authors, not the PR author, so signing from this account doesn't register. |
add linter ignore comment
Summary by CodeRabbit