PMM-15362 Disable default-on node_exporter collectors - #4547
Draft
theTibi wants to merge 1 commit into
Draft
Conversation
Build PMM server and client from the percona/pmm fix branch so the change can be tested as an image. Component PR: percona/pmm#5839 Signed-off-by: theTibi <tkorocz@gmail.com>
14 tasks
Collaborator
|
Server docker: perconalab/pmm-server-fb:PR-4547-6c80a3e |
Collaborator
|
API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7174/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Build for PMM-15362 —
--disable-collectorshad no effect for node_exporter collectors that node_exporter enables by default.Builds PMM Server and Client from the fix branch so the change can be tested as an image. The fix is server-side (
pmm-managedgenerates the exporter command line) plus a one-linepmm-adminchange, so only thepmmmonorepo is pinned.Component PRs
ci.yml
What to check on the built image
pmm-admin inventory change agent node-exporter <agent_id> --disable-collectors=diskstats--no-collector.diskstats(before the fix, the--collector.diskstatsenable flag was merely removed, which is a no-op for a default-on collector).curl -s http://pmm:<agent_id>@127.0.0.1:<port>/metrics | grep -c '^node_disk_'→0(was 324).--disable-collectors=cpu,cpumust not stop node_exporter from starting — a repeated flag is rejected by its flag parser, so the server de-duplicates.--disable-collectors="cpu, meminfo"(with a space) must disable both — thechange agentpath now trims, asaddalready did.--disable-collectors=processes(a non-default collector) must keep working and must not gain a--no-collector.processesflag.Full evidence, including a live before/after on an isolated PMM 3.10.0 server, is in the component PR's test plan.
🤖 Generated with Claude Code